Re: [PATCH] Skip module_cmi_p and related unsupported module test

2023-02-22 Thread Alexandre Oliva via Gcc-patches
On Feb 20, 2023, Jason Merrill wrote: > This seems like an ugly kludge around that problem, but I don't have > any clever ideas of a better approach short of rewriting everything. > So, OK with a comment explaining the rationale above your overridden > "unsupported". > Also, your commit subject

Re: [PATCH] Skip module_cmi_p and related unsupported module test

2023-02-20 Thread Jason Merrill via Gcc-patches
On 2/17/23 22:55, Alexandre Oliva wrote: When a multi-source module is found to be unsupported, we fail module_cmi_p and subsequent sources. Override proc unsupported to mark the result in module_do, and test it to skip module_cmp_p and subsequent related tests. Hmm, I guess the problem that

[PATCH] Skip module_cmi_p and related unsupported module test

2023-02-16 Thread Alexandre Oliva via Gcc-patches
When a multi-source module is found to be unsupported, we fail module_cmi_p and subsequent sources. Override proc unsupported to mark the result in module_do, and test it to skip module_cmp_p and subsequent related tests. Regstrapped on x86_64-linux-gnu. Tested on arm-vxworks7 (gcc-12) and