Re: [PATCH] Use DO_PRAGMA in libgomp.oacc-c-c++-common/reduction-1.c

2015-02-25 Thread Tom de Vries
On 25-02-15 12:40, Thomas Schwinge wrote: Hi! On Mon, 23 Feb 2015 18:14:35 +0100, Tom de Vries tom_devr...@mentor.com wrote: On 23-02-15 17:08, Jakub Jelinek wrote: On Mon, Feb 23, 2015 at 04:52:56PM +0100, Tom de Vries wrote: The only thing I'm not sure about is the two-level pragma

Re: [PATCH] Use DO_PRAGMA in libgomp.oacc-c-c++-common/reduction-1.c

2015-02-25 Thread Thomas Schwinge
Hi! On Mon, 23 Feb 2015 18:14:35 +0100, Tom de Vries tom_devr...@mentor.com wrote: On 23-02-15 17:08, Jakub Jelinek wrote: On Mon, Feb 23, 2015 at 04:52:56PM +0100, Tom de Vries wrote: The only thing I'm not sure about is the two-level pragma expansion using the apply pragmas. It maximizes

[PATCH] Use DO_PRAGMA in libgomp.oacc-c-c++-common/reduction-1.c

2015-02-23 Thread Tom de Vries
Hi, this patch is a rewrite of libgomp.oacc-c-c++-common/reduction-1.c (included as a whole in the patch prefix). The patch attempts to get rid of the errorprone copy-paste style. An example of such an error in this test-case is: ... result = 5; vresult = 5; lresult = false;

Re: [PATCH] Use DO_PRAGMA in libgomp.oacc-c-c++-common/reduction-1.c

2015-02-23 Thread Jakub Jelinek
On Mon, Feb 23, 2015 at 04:52:56PM +0100, Tom de Vries wrote: The only thing I'm not sure about is the two-level pragma expansion using the apply pragmas. It maximizes factoring out common parts, but it makes things less readable. Tested on x86_64. OK for stage4? If Thomas is ok with

Re: [PATCH] Use DO_PRAGMA in libgomp.oacc-c-c++-common/reduction-1.c

2015-02-23 Thread Tom de Vries
On 23-02-15 17:08, Jakub Jelinek wrote: On Mon, Feb 23, 2015 at 04:52:56PM +0100, Tom de Vries wrote: The only thing I'm not sure about is the two-level pragma expansion using the apply pragmas. It maximizes factoring out common parts, but it makes things less readable. Tested on x86_64. OK