Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-14 Thread Sharad Singhai
Teresa, Yes, I didn't take enhancements in google branches into account while porting this patch. In light of these comments, I withdraw this patch and will wait for your patch. Once your patch is in, I will update this patch for regular dumps. To answer your other question, yes, the new dump

[PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Sharad Singhai
Hi, As per discussion in http://gcc.gnu.org/ml/gcc/2012-12/msg00056.html, the attached patch updates loop unroll passes to use new dump infrastructure. This patch filters relevant dump messages into the following three categories - optimized: an optimization was successfully applied - missed:

Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Xinliang David Li
A couple of comments: 1) please dump with source location if possible. What is the use of the information if there is no line number 2) Please do not use the existing dump report -- Loop 1,2,3 etc means nothing to user 3) The optimization report should be standardized with some template (similar

Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Teresa Johnson
On Thu, Dec 13, 2012 at 8:58 PM, Xinliang David Li davi...@google.com wrote: A couple of comments: 1) please dump with source location if possible. What is the use of the information if there is no line number The google branches have the code to identify a source location of the loop, and a