On Thu, Dec 13, 2012 at 11:44:12AM +0400, Konstantin Serebryany wrote:
We are discussing it from time to time.
Sometimes, if e.g. an error happens inside a qsort callback,
the fp-based unwinder fails to unwind through libc, while _Unwind would work.
I was opposed to this sometime ago because
On Thu, Dec 13, 2012 at 02:22:52PM +0400, Konstantin Serebryany wrote:
I've added two flags, both on by default for now.
// Use fast (frame-pointer-based) unwinder on fatal errors (if available).
bool fast_unwind_on_fatal;
// Use fast (frame-pointer-based) unwinder on malloc/free (if
On Wed, Dec 12, 2012 at 10:16:49PM +0100, Dodji Seketeli wrote:
Independently of this review, I think it's be interesting to hear
Kostya's voice on:
Jakub Jelinek ja...@redhat.com writes:
2) In large-func-test-1.C, I had to stop matching the backtrace after
_Znw[jm], because libasan is
Hello,
Independently of this review, I think it's be interesting to hear
Kostya's voice on:
Jakub Jelinek ja...@redhat.com writes:
2) In large-func-test-1.C, I had to stop matching the backtrace after
_Znw[jm], because libasan is using the fast but inaccurate backtrace,
and while the tests
On Thu, Dec 13, 2012 at 1:30 AM, Jakub Jelinek ja...@redhat.com wrote:
On Wed, Dec 12, 2012 at 10:16:49PM +0100, Dodji Seketeli wrote:
Independently of this review, I think it's be interesting to hear
Kostya's voice on:
Jakub Jelinek ja...@redhat.com writes:
2) In large-func-test-1.C, I
Hi!
On Tue, Dec 04, 2012 at 10:00:35AM -0800, Wei Mi wrote:
I updated the patch according to the comments. Please take a look. Thanks.
Rather than several further rounds of review, let me post an incremental
patch on top of yours. Your patch seems to be incomplete BTW, that
asan-special.exp
