Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 11:06:48AM +0400, Konstantin Serebryany wrote: This patch copies the asan tests almost, but not quite, verbatim from upstream. Since the patch is not in attachment (and gmail messes up with inlined patches) I can't see the exact changes. Sending patches inline rather

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 1:18 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Dec 03, 2012 at 11:06:48AM +0400, Konstantin Serebryany wrote: This patch copies the asan tests almost, but not quite, verbatim from upstream. Since the patch is not in attachment (and gmail messes up with inlined

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Jakub Jelinek
On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: I'm attaching the diff for asan_test.cc from llvm anyway. I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like because I'd rather fix the test than disable it. The test isn't disabled, just by default

Re: [PATCH] asan_test.cc from llvm

2012-12-03 Thread Konstantin Serebryany
On Mon, Dec 3, 2012 at 3:05 PM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Dec 03, 2012 at 01:51:50PM +0400, Konstantin Serebryany wrote: I'm attaching the diff for asan_test.cc from llvm anyway. I see #ifdef ASAN_AVOID_EXPENSIVE_TESTS, which I don't really like because I'd rather fix

Re: [PATCH] asan_test.cc from llvm

2012-11-30 Thread Jakub Jelinek
On Fri, Nov 30, 2012 at 01:32:52PM +0400, Konstantin Serebryany wrote: Ideally, I would like to limit the differences from upstream. I'll put some of your changes upstream, for others I'd ask you to consider other choices. -#include gtest/gtest.h +#include dejagnu-gtest.h Maybe like

Re: [PATCH] asan_test.cc from llvm

2012-11-30 Thread Konstantin Serebryany
I've upstreamed most of your changes, please take a look. Looks like we will be able to use libsanitizer/merge.sh to update the test code as well. On Fri, Nov 30, 2012 at 2:14 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Nov 30, 2012 at 01:32:52PM +0400, Konstantin Serebryany wrote:

Re: [PATCH] asan_test.cc from llvm

2012-11-30 Thread Jakub Jelinek
On Fri, Nov 30, 2012 at 02:43:12PM +0400, Konstantin Serebryany wrote: I've upstreamed most of your changes, please take a look. Looks like we will be able to use libsanitizer/merge.sh to update the test code as well. Thanks. #ifndef ASAN_AVOID_EXPENSIVE_TESTS (TEST(AddressSanitizer,

Re: [PATCH] asan_test.cc from llvm

2012-11-30 Thread Jakub Jelinek
Hi! Here is updated patch, I've added also -fno-builtin which cured some failures (will need to analyze exactly later on if it is just assumptions of the test that are not valid with optimized memory/string etc. builtins or if we have issues on the GCC side), the only change in the imported files