Re: [PATCH] asm inline

2018-10-28 Thread Segher Boessenkool
On Sun, Oct 28, 2018 at 01:32:09PM -0400, Eric Gallager wrote: > Since this is touching c_parser_asm_statement() it seems relevant to > bug 55681; could you check to see how it interacts with some of the > cases listed in that bug? > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55681 I wasn't

Re: [PATCH] asm inline

2018-10-28 Thread Eric Gallager
On 10/12/18, Segher Boessenkool wrote: > The Linux kernel people want a feature that makes GCC pretend some > inline assembler code is tiny (while it would think it is huge), so > that such code will be inlined essentially always instead of > essentially never. > > This patch lets you say "asm

Re: [PATCH] asm inline

2018-10-12 Thread Alexander Monakov
On Fri, 12 Oct 2018, Segher Boessenkool wrote: > > Please consider that as currently GCC over-estimates length of such asms, > > branches around them are emitted as long-range jumps more often than needed, > > which should be a problem we'd want to solve, because the whole reason this > > is being

Re: [PATCH] asm inline

2018-10-12 Thread Segher Boessenkool
On Fri, Oct 12, 2018 at 07:57:12PM +0300, Alexander Monakov wrote: > > I don't agree at all. Sure it is not very many lines to implement this, > > but it will make the semantics of inline assembler even stranger than it > > already is. > > > > I also don't think it will be very useful. > > > >

Re: [PATCH] asm inline

2018-10-12 Thread Alexander Monakov
On Fri, 12 Oct 2018, Segher Boessenkool wrote: > > For instance by introducing special tokens like %[ %] that demarkate > > portion of the asm that shouldn't be counted: > > This potentially conflicts with targetm.asm_out.print_operand_punct_valid_p > (and it does in fact conflict for

Re: [PATCH] asm inline

2018-10-12 Thread Segher Boessenkool
On Fri, Oct 12, 2018 at 03:45:41PM +0300, Alexander Monakov wrote: > On Fri, 12 Oct 2018, Segher Boessenkool wrote: > > > The Linux kernel people want a feature that makes GCC pretend some > > inline assembler code is tiny (while it would think it is huge), so > > that such code will be inlined

Re: [PATCH] asm inline

2018-10-12 Thread Jakub Jelinek
On Fri, Oct 12, 2018 at 08:13:51AM -0500, Segher Boessenkool wrote: > On Fri, Oct 12, 2018 at 02:38:52PM +0200, Jakub Jelinek wrote: > > On Fri, Oct 12, 2018 at 12:21:06PM +, Segher Boessenkool wrote: > > > The Linux kernel people want a feature that makes GCC pretend some > > > inline

Re: [PATCH] asm inline

2018-10-12 Thread Segher Boessenkool
On Fri, Oct 12, 2018 at 02:38:52PM +0200, Jakub Jelinek wrote: > On Fri, Oct 12, 2018 at 12:21:06PM +, Segher Boessenkool wrote: > > The Linux kernel people want a feature that makes GCC pretend some > > inline assembler code is tiny (while it would think it is huge), so > > that such code

Re: [PATCH] asm inline

2018-10-12 Thread Alexander Monakov
On Fri, 12 Oct 2018, Segher Boessenkool wrote: > The Linux kernel people want a feature that makes GCC pretend some > inline assembler code is tiny (while it would think it is huge), so > that such code will be inlined essentially always instead of > essentially never. I do apologize for being

Re: [PATCH] asm inline

2018-10-12 Thread Jakub Jelinek
On Fri, Oct 12, 2018 at 12:21:06PM +, Segher Boessenkool wrote: > The Linux kernel people want a feature that makes GCC pretend some > inline assembler code is tiny (while it would think it is huge), so > that such code will be inlined essentially always instead of > essentially never. Just a

[PATCH] asm inline

2018-10-12 Thread Segher Boessenkool
The Linux kernel people want a feature that makes GCC pretend some inline assembler code is tiny (while it would think it is huge), so that such code will be inlined essentially always instead of essentially never. This patch lets you say "asm inline" instead of just "asm", with the result that