Re: [PATCH] attribs: Fix ICE with -Wno-attributes= [PR112339]

2023-11-07 Thread Marek Polacek
On Fri, Nov 03, 2023 at 06:43:49PM -0400, Jason Merrill wrote: > LGTM but I'd like Marek to approve it. Both hunks look correct to me. Patch is OK, thanks! > On Fri, Nov 3, 2023, 3:12 PM Jakub Jelinek wrote: > > > Hi! > > > > The following testcase ICEs, because with

Re: [PATCH] attribs: Fix ICE with -Wno-attributes= [PR112339]

2023-11-03 Thread Jason Merrill
LGTM but I'd like Marek to approve it. On Fri, Nov 3, 2023, 3:12 PM Jakub Jelinek wrote: > Hi! > > The following testcase ICEs, because with -Wno-attributes=foo::no_sanitize > (but generally any other non-gnu namespace and some gnu well known > attribute > name within that other namespace) the

[PATCH] attribs: Fix ICE with -Wno-attributes= [PR112339]

2023-11-03 Thread Jakub Jelinek
Hi! The following testcase ICEs, because with -Wno-attributes=foo::no_sanitize (but generally any other non-gnu namespace and some gnu well known attribute name within that other namespace) the FEs don't really parse attribute arguments of such attribute, but lookup_attribute_spec is non-NULL