Re: [PATCH] c++/modules: anon union member of as-base class [PR112580]

2024-02-09 Thread Jason Merrill
On 2/1/24 12:18, Patrick Palka wrote: Tested on x86_64-pc-linux-gnu, does this look OK for trunk? OK. -- >8 -- Here when streaming in the fields of the as-base version of _Formatting_scanner we end up clobbering ANON_AGGR_TYPE_FIELD of the anonymous union type, since it turns out this type

Re: [PATCH] c++/modules: anon union member of as-base class [PR112580]

2024-02-08 Thread Patrick Palka
On Thu, 1 Feb 2024, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? Ping. FWIW this fixes the remaining reported xtreme-header FAILs on x86_64-linux with -mx32 (not totally sure why the fails don't happen without -mx32). > > -- >8 -- > > Here when streaming

[PATCH] c++/modules: anon union member of as-base class [PR112580]

2024-02-01 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Here when streaming in the fields of the as-base version of _Formatting_scanner we end up clobbering ANON_AGGR_TYPE_FIELD of the anonymous union type, since it turns out this type is shared between the original FIELD_DECL and