Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-04-06 Thread Jason Merrill via Gcc-patches
On 4/6/22 11:26, Jakub Jelinek wrote: On Wed, Apr 06, 2022 at 11:18:32AM -0400, Jason Merrill wrote: Why not check at the beginning of the function? You just pinged this patch, but I haven't seen a response to this question. I thought the

Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-04-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Apr 06, 2022 at 11:18:32AM -0400, Jason Merrill wrote: > > Why not check at the beginning of the function? > > You just pinged this patch, but I haven't seen a response to this question. I thought the https://gcc.gnu.org/pipermail/gcc-patches/2022-March/592368.html is the response to

Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-04-06 Thread Jason Merrill via Gcc-patches
On 3/25/22 14:08, Jason Merrill wrote: On 3/25/22 12:34, Jakub Jelinek wrote: Hi! cplus_decl_attributes can be called with attributes equal to error_mark_node, there are some spots in the function that test it or decl_attributes it calls starts with:    if (TREE_TYPE (*node) == error_mark_node

Ping Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-04-06 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 07:55:56PM +0100, Jakub Jelinek via Gcc-patches wrote: > On Fri, Mar 25, 2022 at 07:48:33PM +0100, Jakub Jelinek wrote: > > We then wouldn't propagate TREE_DEPRECATED/TREE_UNAVAILABLE from templates > > to their instantiations and wouldn't diagnose static data members in

Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-03-28 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 07:48:33PM +0100, Jakub Jelinek wrote: > We then wouldn't propagate TREE_DEPRECATED/TREE_UNAVAILABLE from templates > to their instantiations and wouldn't diagnose static data members in OpenMP > declare target. > But perhaps that is fine, with error_mark_attribute it is

Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/25/22 12:34, Jakub Jelinek wrote: Hi! cplus_decl_attributes can be called with attributes equal to error_mark_node, there are some spots in the function that test it or decl_attributes it calls starts with: if (TREE_TYPE (*node) == error_mark_node || attributes == error_mark_node)

[PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
Hi! cplus_decl_attributes can be called with attributes equal to error_mark_node, there are some spots in the function that test it or decl_attributes it calls starts with: if (TREE_TYPE (*node) == error_mark_node || attributes == error_mark_node) return NULL_TREE; But the recent PR104245