Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Marek Polacek
On Mon, Mar 02, 2020 at 11:59:12AM -0500, Jason Merrill wrote: > On 3/2/20 11:38 AM, Jeff Law wrote: > > On Mon, 2020-03-02 at 11:29 -0500, Marek Polacek wrote: > > > On Mon, Mar 02, 2020 at 09:25:35AM -0700, Jeff Law wrote: > > > > On Mon, 2020-03-02 at 10:45 -0500, Marek Polacek wrote: > > > > >

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Jason Merrill
On 3/2/20 11:38 AM, Jeff Law wrote: On Mon, 2020-03-02 at 11:29 -0500, Marek Polacek wrote: On Mon, Mar 02, 2020 at 09:25:35AM -0700, Jeff Law wrote: On Mon, 2020-03-02 at 10:45 -0500, Marek Polacek wrote: Ping: Jeff, see the question below. Thanks. Sorry, totally missed the question. I'm

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Jeff Law
On Mon, 2020-03-02 at 11:29 -0500, Marek Polacek wrote: > On Mon, Mar 02, 2020 at 09:25:35AM -0700, Jeff Law wrote: > > On Mon, 2020-03-02 at 10:45 -0500, Marek Polacek wrote: > > > Ping: Jeff, see the question below. Thanks. > > Sorry, totally missed the question. I'm guessing you want me to

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Marek Polacek
On Mon, Mar 02, 2020 at 09:25:35AM -0700, Jeff Law wrote: > On Mon, 2020-03-02 at 10:45 -0500, Marek Polacek wrote: > > Ping: Jeff, see the question below. Thanks. > Sorry, totally missed the question. I'm guessing you want me to run it > through > the Fedora build tester? Yeah -- we want to

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Jeff Law
On Mon, 2020-03-02 at 10:45 -0500, Marek Polacek wrote: > Ping: Jeff, see the question below. Thanks. Sorry, totally missed the question. I'm guessing you want me to run it through the Fedora build tester? jeff >

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-03-02 Thread Marek Polacek
Ping: Jeff, see the question below. Thanks. On Mon, Feb 24, 2020 at 10:19:20AM -0500, Marek Polacek wrote: > On Mon, Feb 24, 2020 at 09:59:51AM -0500, Jason Merrill wrote: > > On 2/24/20 9:58 AM, Jason Merrill wrote: > > > On 2/21/20 2:14 PM, Marek Polacek wrote: > > > > This was approved in the

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-02-24 Thread Marek Polacek
On Mon, Feb 24, 2020 at 09:59:51AM -0500, Jason Merrill wrote: > On 2/24/20 9:58 AM, Jason Merrill wrote: > > On 2/21/20 2:14 PM, Marek Polacek wrote: > > > This was approved in the Prague 2020 WG21 meeting so let's adjust the > > > comment.  Since it's supposed to be a DR I think we should no

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-02-24 Thread Jason Merrill
On 2/24/20 9:58 AM, Jason Merrill wrote: On 2/21/20 2:14 PM, Marek Polacek wrote: This was approved in the Prague 2020 WG21 meeting so let's adjust the comment.  Since it's supposed to be a DR I think we should no longer limit it to C++20. I'm a bit nervous about the impact, but OK.  It's

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-02-24 Thread Jason Merrill
On 2/21/20 2:14 PM, Marek Polacek wrote: This was approved in the Prague 2020 WG21 meeting so let's adjust the comment. Since it's supposed to be a DR I think we should no longer limit it to C++20. I'm a bit nervous about the impact, but OK. It's easy enough to turn off -Wnarrowing if it's

Re: [PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-02-21 Thread Marek Polacek
On Fri, Feb 21, 2020 at 02:14:26PM -0500, Marek Polacek wrote: > This was approved in the Prague 2020 WG21 meeting so let's adjust the > comment. Since it's supposed to be a DR I think we should no longer > limit it to C++20. Which is what clang++ trunk does. Marek

[PATCH] c++: Implement P1957R2, T* to bool should be considered narrowing.

2020-02-21 Thread Marek Polacek
This was approved in the Prague 2020 WG21 meeting so let's adjust the comment. Since it's supposed to be a DR I think we should no longer limit it to C++20. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2020-02-21 Marek Polacek P1957R2 * typeck2.c (check_narrowing):