Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-31 Thread H.J. Lu
On Thu, Jul 31, 2025 at 8:11 AM Alexander Monakov wrote: > > > On Thu, 31 Jul 2025, H.J. Lu wrote: > > > > We have a few pre-existing tests that verify that the attribute is > > > honored, > > > such as those added by commit 1d561e1851c4. Do they actually not fail with > > > this patch? > > > > T

Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-31 Thread Alexander Monakov
On Thu, 31 Jul 2025, H.J. Lu wrote: > > We have a few pre-existing tests that verify that the attribute is honored, > > such as those added by commit 1d561e1851c4. Do they actually not fail with > > this patch? > > There are no regressions. Sorry, I don't see how that would be possible, that's

Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-31 Thread H.J. Lu
On Thu, Jul 31, 2025 at 6:58 AM Alexander Monakov wrote: > > > On Wed, 30 Jul 2025, H.J. Lu wrote: > > > According to the TLS spec, linker can optimize the TLS access by > > overriding the TLS access model. Do the same in compiler by using > > the default TLS mode if it is more optimized than the

Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-31 Thread Alexander Monakov
On Wed, 30 Jul 2025, H.J. Lu wrote: > According to the TLS spec, linker can optimize the TLS access by > overriding the TLS access model. Do the same in compiler by using > the default TLS mode if it is more optimized than the TLS model > attribute. > > gcc/ > > PR c/121318 > * do

Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-30 Thread H.J. Lu
On Wed, Jul 30, 2025 at 8:24 PM Andrew Pinski wrote: > > On Wed, Jul 30, 2025 at 5:33 PM H.J. Lu wrote: > > > > According to the TLS spec, linker can optimize the TLS access by > > overriding the TLS access model. Do the same in compiler by using > > the default TLS mode if it is more optimized

Re: [PATCH] c: Use the default TLS mode if it is more optimized

2025-07-30 Thread Andrew Pinski
On Wed, Jul 30, 2025 at 5:33 PM H.J. Lu wrote: > > According to the TLS spec, linker can optimize the TLS access by > overriding the TLS access model. Do the same in compiler by using > the default TLS mode if it is more optimized than the TLS model > attribute. So reading the old bug reports sp

[PATCH] c: Use the default TLS mode if it is more optimized

2025-07-30 Thread H.J. Lu
According to the TLS spec, linker can optimize the TLS access by overriding the TLS access model. Do the same in compiler by using the default TLS mode if it is more optimized than the TLS model attribute. gcc/ PR c/121318 * doc/extend.texi: Update the tls_model attribute. gcc/c