Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-10 Thread Jiufu Guo
Jan Hubicka writes: >> On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote: >> > On 2/3/20 2:17 AM, Jiufu Guo wrote: >> > > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 >> > > "loop2_unroll"} } */ >> > >> > Sorry I didn't catch this addition to the original testcase >> >

Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-03 Thread Jan Hubicka
> On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote: > > On 2/3/20 2:17 AM, Jiufu Guo wrote: > > > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 > > > "loop2_unroll"} } */ > > > > Sorry I didn't catch this addition to the original testcase earlier, but I > > wonder how stable

Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-03 Thread Jeff Law
On Mon, 2020-02-03 at 10:04 -0600, Pat Haugen wrote: > On 2/3/20 2:17 AM, Jiufu Guo wrote: > > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 > > "loop2_unroll"} } */ > > Sorry I didn't catch this addition to the original testcase earlier, but I > wonder how stable this test is

Re: [PATCH] correct COUNT and PROB for unrolled loop

2020-02-03 Thread Pat Haugen
On 2/3/20 2:17 AM, Jiufu Guo wrote: > +/* { dg-final { scan-rtl-dump-times "REG_BR_PROB 937042044" 1 > "loop2_unroll"} } */ Sorry I didn't catch this addition to the original testcase earlier, but I wonder how stable this test is going to be. If there are future changes to default

[PATCH] correct COUNT and PROB for unrolled loop

2020-02-03 Thread Jiufu Guo
Hi, PR68212 mentioned that the COUNT of unrolled loop was not correct, and comments of this PR also mentioned that loop become 'cold'. The patches of the PR fixed part of the issue. With reference the patch (https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02368.html) and comment