Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-08-06 Thread Christophe Lyon via Gcc-patches
On Fri, Aug 6, 2021 at 9:52 AM Christophe Lyon < christophe.lyon@gmail.com> wrote: > > > On Fri, Aug 6, 2021 at 4:07 AM Martin Sebor via Gcc-patches < > gcc-patches@gcc.gnu.org> wrote: > >> On 7/30/21 9:06 AM, Jason Merrill wrote: >> > On 7/27/21 2:56 PM, Martin Sebor wrote: >> >> Ping:

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-08-06 Thread Christophe Lyon via Gcc-patches
On Fri, Aug 6, 2021 at 4:07 AM Martin Sebor via Gcc-patches < gcc-patches@gcc.gnu.org> wrote: > On 7/30/21 9:06 AM, Jason Merrill wrote: > > On 7/27/21 2:56 PM, Martin Sebor wrote: > >> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575690.html > >> > >> Are there any other suggestions

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-08-05 Thread Martin Sebor via Gcc-patches
On 7/30/21 9:06 AM, Jason Merrill wrote: On 7/27/21 2:56 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575690.html Are there any other suggestions or comments or is the latest revision okay to commit? OK. I had to make a few more adjustments to fix up

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-30 Thread Jason Merrill via Gcc-patches
On 7/27/21 2:56 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575690.html Are there any other suggestions or comments or is the latest revision okay to commit? OK. On 7/20/21 12:34 PM, Martin Sebor wrote: On 7/14/21 10:23 AM, Jason Merrill wrote: On

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-27 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575690.html Are there any other suggestions or comments or is the latest revision okay to commit? On 7/20/21 12:34 PM, Martin Sebor wrote: On 7/14/21 10:23 AM, Jason Merrill wrote: On 7/14/21 10:46 AM, Martin Sebor wrote: On 7/13/21

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-20 Thread Martin Sebor via Gcc-patches
On 7/20/21 2:08 PM, Jason Merrill wrote: On 7/20/21 2:34 PM, Martin Sebor wrote: On 7/14/21 10:23 AM, Jason Merrill wrote: On 7/14/21 10:46 AM, Martin Sebor wrote: On 7/13/21 9:39 PM, Jason Merrill wrote: On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-20 Thread Jason Merrill via Gcc-patches
On 7/20/21 2:34 PM, Martin Sebor wrote: On 7/14/21 10:23 AM, Jason Merrill wrote: On 7/14/21 10:46 AM, Martin Sebor wrote: On 7/13/21 9:39 PM, Jason Merrill wrote: On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote:

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-20 Thread Martin Sebor via Gcc-patches
On 7/14/21 10:23 AM, Jason Merrill wrote: On 7/14/21 10:46 AM, Martin Sebor wrote: On 7/13/21 9:39 PM, Jason Merrill wrote: On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-14 Thread Jason Merrill via Gcc-patches
On 7/14/21 10:46 AM, Martin Sebor wrote: On 7/13/21 9:39 PM, Jason Merrill wrote: On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: Somebody with more C++

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-14 Thread Martin Sebor via Gcc-patches
On 7/13/21 9:39 PM, Jason Merrill wrote: On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: Somebody with more C++ knowledge than me needs to approve the vec.h

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-14 Thread Martin Sebor via Gcc-patches
On 7/12/21 5:02 AM, Richard Biener wrote: On Wed, Jul 7, 2021 at 4:37 PM Martin Sebor wrote: On 7/7/21 1:28 AM, Richard Biener wrote: On Tue, Jul 6, 2021 at 5:06 PM Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html Any questions/suggestions on the

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-14 Thread Jonathan Wakely via Gcc-patches
On Wed, 14 Jul 2021 at 04:39, Jason Merrill wrote: > > On 7/13/21 4:02 PM, Martin Sebor wrote: > > On 7/13/21 12:37 PM, Jason Merrill wrote: > >> On 7/13/21 10:08 AM, Jonathan Wakely wrote: > >>> On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: > Somebody with more C++ knowledge than me

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-13 Thread Jason Merrill via Gcc-patches
On 7/13/21 4:02 PM, Martin Sebor wrote: On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: Somebody with more C++ knowledge than me needs to approve the vec.h changes - I don't feel competent to assess all

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-13 Thread Martin Sebor via Gcc-patches
On 7/13/21 12:37 PM, Jason Merrill wrote: On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: Somebody with more C++ knowledge than me needs to approve the vec.h changes - I don't feel competent to assess all effects of the change. They look OK to

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-13 Thread Jason Merrill via Gcc-patches
On 7/13/21 10:08 AM, Jonathan Wakely wrote: On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: Somebody with more C++ knowledge than me needs to approve the vec.h changes - I don't feel competent to assess all effects of the change. They look OK to me except for: -extern vnull vNULL;

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-13 Thread Jonathan Wakely via Gcc-patches
On Mon, 12 Jul 2021 at 12:02, Richard Biener wrote: > Somebody with more C++ knowledge than me needs to approve the > vec.h changes - I don't feel competent to assess all effects of the change. They look OK to me except for: -extern vnull vNULL; +static constexpr vnull vNULL{ }; Making vNULL

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-12 Thread Richard Biener via Gcc-patches
On Wed, Jul 7, 2021 at 4:37 PM Martin Sebor wrote: > > On 7/7/21 1:28 AM, Richard Biener wrote: > > On Tue, Jul 6, 2021 at 5:06 PM Martin Sebor wrote: > >> > >> Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html > >> > >> Any questions/suggestions on the final patch or is it

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-07 Thread Martin Sebor via Gcc-patches
On 7/7/21 1:28 AM, Richard Biener wrote: On Tue, Jul 6, 2021 at 5:06 PM Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html Any questions/suggestions on the final patch or is it okay to commit? I don't remember seeing one (aka saying

Re: [PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-07 Thread Richard Biener via Gcc-patches
On Tue, Jul 6, 2021 at 5:06 PM Martin Sebor wrote: > > Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html > > Any questions/suggestions on the final patch or is it okay to commit? I don't remember seeing one (aka saying "bootstrapped/tested, OK to commit?" or so) - and the

[PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-07-06 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573968.html Any questions/suggestions on the final patch or is it okay to commit? On 6/29/21 7:46 PM, Martin Sebor wrote: On 6/29/21 4:58 AM, Richard Biener wrote: On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: On 6/28/21 2:07

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Wed, Jun 30, 2021 at 11:00 AM Richard Sandiford wrote: > > Richard Biener via Gcc-patches writes: > > Note there's also array_slice<> which could be used to pass non-const > > vec<>s that are never resized but modified - the only "valid" case of > > passing a non-const vec<> by value. > >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Martin Jambor
Hi, On Wed, Jun 30 2021, Richard Biener wrote: > On Wed, Jun 30, 2021 at 3:46 AM Martin Sebor wrote: >> On 6/29/21 4:58 AM, Richard Biener wrote: [...] >> > >> > But I wonder if since you now identified them they could be massaged >> > prior to doing the change. >> > >> > I do hope we end up

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > Note there's also array_slice<> which could be used to pass non-const > vec<>s that are never resized but modified - the only "valid" case of > passing a non-const vec<> by value. Yeah. We'd need a new constructor for that (the current one only takes

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Wed, Jun 30, 2021 at 3:46 AM Martin Sebor wrote: > > On 6/29/21 4:58 AM, Richard Biener wrote: > > On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: > >> > >> On 6/28/21 2:07 AM, Richard Biener wrote: > >>> On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-30 Thread Richard Biener via Gcc-patches
On Tue, Jun 29, 2021 at 7:18 PM Martin Sebor wrote: > > On 6/29/21 8:43 AM, Jason Merrill wrote: > > On 6/28/21 2:07 PM, Martin Sebor wrote: > >> On 6/28/21 2:07 AM, Richard Biener wrote: > >>> On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11 PM, Jason Merrill

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Sebor via Gcc-patches
On 6/29/21 4:58 AM, Richard Biener wrote: On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Sebor via Gcc-patches
On 6/29/21 8:43 AM, Jason Merrill wrote: On 6/28/21 2:07 PM, Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Jason Merrill via Gcc-patches
On 6/28/21 2:07 PM, Martin Sebor wrote: On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Trevor Saunders
On Fri, Jun 25, 2021 at 02:51:58PM -0600, Martin Sebor via Gcc-patches wrote: > On 6/1/21 3:38 PM, Jason Merrill wrote: > > On 6/1/21 3:56 PM, Martin Sebor wrote: > > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > > > > > On 4/27/21

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Martin Jambor
Hi, On Tue, Jun 29 2021, Richard Biener via Gcc-patches wrote: > On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: [...] >> >> vNULL can bind to a const vec& (via the vec conversion ctor) but >> not to vec&. The three functions that in the patch are passed >> vNULL modify the argument when

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-29 Thread Richard Biener via Gcc-patches
On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: > > On 6/28/21 2:07 AM, Richard Biener wrote: > > On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > >> > >> On 6/25/21 4:11 PM, Jason Merrill wrote: > >>> On 6/25/21 4:51 PM, Martin Sebor wrote: > On 6/1/21 3:38 PM, Jason Merrill

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Martin Sebor via Gcc-patches
On 6/28/21 2:07 AM, Richard Biener wrote: On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Richard Biener via Gcc-patches
On Sat, Jun 26, 2021 at 12:36 AM Martin Sebor wrote: > > On 6/25/21 4:11 PM, Jason Merrill wrote: > > On 6/25/21 4:51 PM, Martin Sebor wrote: > >> On 6/1/21 3:38 PM, Jason Merrill wrote: > >>> On 6/1/21 3:56 PM, Martin Sebor wrote: > On 5/27/21 2:53 PM, Jason Merrill wrote: > > On

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-28 Thread Richard Biener via Gcc-patches
On Fri, Jun 25, 2021 at 10:52 PM Martin Sebor wrote: > > On 6/1/21 3:38 PM, Jason Merrill wrote: > > On 6/1/21 3:56 PM, Martin Sebor wrote: > >> On 5/27/21 2:53 PM, Jason Merrill wrote: > >>> On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > On 4/27/21 8:04 AM, Richard Biener wrote:

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Martin Sebor via Gcc-patches
On 6/25/21 4:11 PM, Jason Merrill wrote: On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Jason Merrill via Gcc-patches
On 6/25/21 4:51 PM, Martin Sebor wrote: On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-25 Thread Martin Sebor via Gcc-patches
On 6/1/21 3:38 PM, Jason Merrill wrote: On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-08 Thread Richard Biener via Gcc-patches
On Tue, Jun 8, 2021 at 5:26 AM Trevor Saunders wrote: > > On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > > On 6/7/21 2:51 AM, Richard Biener wrote: > > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > > wrote: > > > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > On 6/7/21 2:51 AM, Richard Biener wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > > wrote: > > > > On 6/2/21 12:55 AM,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 04:17:09PM -0600, Martin Sebor wrote: > On 6/3/21 2:29 AM, Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/3/21 2:29 AM, Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/7/21 2:51 AM, Richard Biener wrote: On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 12:33 PM Trevor Saunders wrote: > > On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches > wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches wrote: > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote:

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-03 Thread Trevor Saunders
On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > On 6/2/21 12:55 AM, Richard Biener wrote: > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: >

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-02 Thread Martin Sebor via Gcc-patches
On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-02 Thread Richard Biener via Gcc-patches
On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > On 5/27/21 2:53 PM, Jason Merrill wrote: > > On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: > >> On 4/27/21 8:04 AM, Richard Biener wrote: > >>> On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: > > On 4/27/21 1:58 AM,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-01 Thread Jason Merrill via Gcc-patches
On 6/1/21 3:56 PM, Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27,

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-01 Thread Martin Sebor via Gcc-patches
On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-05-27 Thread Jason Merrill via Gcc-patches
On 4/27/21 11:52 AM, Martin Sebor via Gcc-patches wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that

[PING 3][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-05-27 Thread Martin Sebor via Gcc-patches
Jason, I wonder if you could review this patch that Richard has apparently decided to defer to others. https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568901.html Thanks On 5/11/21 2:02 PM, Martin Sebor wrote: Ping 2: https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568901.html On

[PING 2][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-05-11 Thread Martin Sebor via Gcc-patches
Ping 2: https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568901.html On 5/3/21 3:50 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568901.html On 4/27/21 9:52 AM, Martin Sebor wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at

[PING][PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-05-03 Thread Martin Sebor via Gcc-patches
Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568901.html On 4/27/21 9:52 AM, Martin Sebor wrote: On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Martin Sebor via Gcc-patches
On 4/27/21 8:04 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that auto_vec is unsafe to copy and assign because the class manages

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Richard Biener via Gcc-patches
On Tue, Apr 27, 2021 at 3:59 PM Martin Sebor wrote: > > On 4/27/21 1:58 AM, Richard Biener wrote: > > On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches > > wrote: > >> > >> PR 90904 notes that auto_vec is unsafe to copy and assign because > >> the class manages its own memory but

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Martin Sebor via Gcc-patches
On 4/27/21 1:58 AM, Richard Biener wrote: On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: PR 90904 notes that auto_vec is unsafe to copy and assign because the class manages its own memory but doesn't define (or delete) either special function. Since I first ran into the

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-27 Thread Richard Biener via Gcc-patches
On Tue, Apr 27, 2021 at 2:46 AM Martin Sebor via Gcc-patches wrote: > > PR 90904 notes that auto_vec is unsafe to copy and assign because > the class manages its own memory but doesn't define (or delete) > either special function. Since I first ran into the problem, > auto_vec has grown a move

[PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-04-26 Thread Martin Sebor via Gcc-patches
PR 90904 notes that auto_vec is unsafe to copy and assign because the class manages its own memory but doesn't define (or delete) either special function. Since I first ran into the problem, auto_vec has grown a move ctor and move assignment from a dynamically-allocated vec but still no copy