Jason, can you take a look? Thanks.
Ian
On Tue, Aug 19, 2014 at 3:46 AM, Gary Benson gben...@redhat.com wrote:
Hi all,
I just retested this patch. The crash it fixes is still there,
and the patch still fixes it. Is this ok to commit?
Cheers,
Gary
Andrew Burgess wrote:
In two places
Hi all,
I just retested this patch. The crash it fixes is still there,
and the patch still fixes it. Is this ok to commit?
Cheers,
Gary
Andrew Burgess wrote:
In two places when a struct demangle_component is of type
DEMANGLE_COMPONENT_FIXED_TYPE we fall back to accessing the default
Ping!
Thanks for your time,
Andrew
On 29/05/2014 1:02 AM, Andrew Burgess wrote:
On 28/05/2014 11:56 PM, Pedro Alves wrote:
On 05/28/2014 09:38 PM, Andrew Burgess wrote:
diff --git a/libiberty/testsuite/demangle-expected
b/libiberty/testsuite/demangle-expected
index 453f9a3..0e2bb12 100644
In two places when a struct demangle_component is of type
DEMANGLE_COMPONENT_FIXED_TYPE we fall back to accessing the default
s_binary member of the union rather than the s_fixed member. This is
incorrect and can cause the demangler to crash.
In d_dump I've changed the code to only access the
On 05/28/2014 09:38 PM, Andrew Burgess wrote:
In two places when a struct demangle_component is of type
DEMANGLE_COMPONENT_FIXED_TYPE we fall back to accessing the default
s_binary member of the union rather than the s_fixed member. This is
incorrect and can cause the demangler to crash.
On 28/05/2014 11:56 PM, Pedro Alves wrote:
On 05/28/2014 09:38 PM, Andrew Burgess wrote:
diff --git a/libiberty/testsuite/demangle-expected
b/libiberty/testsuite/demangle-expected
index 453f9a3..0e2bb12 100644
--- a/libiberty/testsuite/demangle-expected
+++