On Wed, Aug 25, 2021 at 9:45 AM David Malcolm wrote:
> > BTW, do you think it would be worthwhile to work on the other half of
> > encoding support, i.e. translating from UTF-8 to the user's locale,
> > when outputting diagnostics? I have probably 90% of a patch that does
> > this, however it
On Tue, 2021-08-24 at 19:28 -0400, Lewis Hyatt wrote:
> On Tue, Aug 24, 2021 at 6:51 PM David Malcolm
> wrote:
> >
> > On Tue, 2021-08-24 at 08:17 -0400, Lewis Hyatt wrote:
> > > Hello-
> > >
> > > I thought it might be a good time to check on this patch please?
> > > Thanks!
> > >
On Tue, Aug 24, 2021 at 6:51 PM David Malcolm wrote:
>
> On Tue, 2021-08-24 at 08:17 -0400, Lewis Hyatt wrote:
> > Hello-
> >
> > I thought it might be a good time to check on this patch please?
> > Thanks!
> > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576449.html
> >
> > -Lewis
>
> I
On Tue, 2021-08-24 at 08:17 -0400, Lewis Hyatt wrote:
> Hello-
>
> I thought it might be a good time to check on this patch please?
> Thanks!
> https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576449.html
>
> -Lewis
I went through that latest version of the patch and have no further
(input_cset, input, len, ))
> > > > - cpp_error (pfile, CPP_DL_ERROR,
> > > > - "failure to convert %s to %s",
> > > > - CPP_OPTION (pfile, input_charset),
> > > SOURCE_CHARSET);
> > >
+CPP_OPTION (pfile, input_charset),
> > SOURCE_CHARSET);
> > > + }
> > > +}
> > >
> >
> > Doesn't this lose the
> > free (input);
> > for the case where the conversion is successful? Is this a leak?
> >
On Tue, May 18, 2021 at 5:31 AM Iain Buclaw wrote:
>
> Excerpts from Lewis Hyatt via Gcc-patches's message of January 29, 2021 4:46
> pm:
> > Q1: What is the input charset?
> > A1:
> >
> > libcpp: Whatever was passed to -finput-charset (note, for Fortran,
> > -finput-charset is not
Excerpts from Lewis Hyatt via Gcc-patches's message of January 29, 2021 4:46 pm:
> Q1: What is the input charset?
> A1:
>
> libcpp: Whatever was passed to -finput-charset (note, for Fortran,
> -finput-charset is not supported though.)
>
> go: Assume UTF-8.
>
> D: UTF-8, UTF-16,
> > + cpp_error (pfile, CPP_DL_ERROR,
> > > +"failure to convert %s to %s",
> > > +CPP_OPTION (pfile, input_charset),
> > SOURCE_CHARSET);
> > > + }
> > > +}
> > >
> >
before the patch, so rather
> than add a default argument, I think it's simpler to pass in the
> input_charset at that call.
>
> > @@ -671,18 +671,32 @@ _cpp_find_file (cpp_reader *pfile, const char
> *fname, cpp_dir *start_dir,
> >
> > Use LOC for any diagnostic
On Fri, 2020-12-18 at 18:03 -0500, Lewis Hyatt wrote:
> Hello-
>
> The attached patch addresses PR93067:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93067#c0
>
> This is similar to the patch I posted last year on the PR, with some
tweaks
> to make it a little simpler. Recapping some of the
Hello-
The attached patch addresses PR93067:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93067#c0
This is similar to the patch I posted last year on the PR, with some tweaks
to make it a little simpler. Recapping some of the commentary on the PR:
When source lines are needed for diagnostics
12 matches
Mail list logo
