Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

On 06/12/2018 09:19 AM, Olivier Hainque wrote: > > >> On 12 Jun 2018, at 16:58, Jeff Law wrote: > >> Installed on the trunk. > > Thanks Jeff. I missed that Rasmus doesn't have commit rights. No worries. I'm thinking that Rasmus ought to go ahead and get commit privs since it seems like he's

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

> On 12 Jun 2018, at 16:58, Jeff Law wrote: > Installed on the trunk. Thanks Jeff. I missed that Rasmus doesn't have commit rights.

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

On 06/12/2018 03:17 AM, Olivier Hainque wrote: > Hello Rasmus, > >> On 7 Jun 2018, at 11:50, Rasmus Villemoes wrote: >> >> 2018-06-07Rasmus Villemoes >> >> fixinclude/ >> >> * inclhack.def: Fix fixup for assert.h on vxworks. >> * fixincl.x: Regenerate. > > Ok by me, thanks.

Re: [PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

Hello Rasmus, > On 7 Jun 2018, at 11:50, Rasmus Villemoes wrote: > > 2018-06-07Rasmus Villemoes > > fixinclude/ > > * inclhack.def: Fix fixup for assert.h on vxworks. > * fixincl.x: Regenerate. Ok by me, thanks. Olivier

[PATCH] fixincludes: partly repair broken fix for assert.h in vxworks

The current "fix" for assert.h on vxworks is itself broken in a number of ways. First, assert.h is special in that it should _not_ have an include guard - the user is allowed to include it multiple times with different definedness of _NDEBUG to enable and disable assert() in parts of a TU.