Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-31 Thread Jeff Law via Gcc-patches
On 7/28/23 15:11, Joseph Myers wrote: This patch is OK. I fixed the whitespace errors in the patch as well as a couple minor ChangeLog entry items and pushed Costas's patch to the trunk. jeff

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-28 Thread Joseph Myers
This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-28 Thread Costas Argyris via Gcc-patches
ping On Fri, 14 Jul 2023 at 09:05, Costas Argyris wrote: > Pinging to try and get this bug in gcc-ar fixed. > > Note that the patch posted as an attachment in > > https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623400.html > > is exactly the same as the patch embedded in > >

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-14 Thread Costas Argyris via Gcc-patches
Pinging to try and get this bug in gcc-ar fixed. Note that the patch posted as an attachment in https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623400.html is exactly the same as the patch embedded in https://gcc.gnu.org/pipermail/gcc-patches/2023-July/623855.html and the one posted in

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-07 Thread Costas Argyris via Gcc-patches
Bootstrapped successfully on x86_64-pc-linux-gnu On Fri, 7 Jul 2023 at 11:33, Costas Argyris wrote: > Problem: gcc-ar fails when a @file is passed to it: > > $ cat rsp > --version > $ gcc-ar @rsp > /usr/bin/ar: invalid option -- '@' > > This is because a dash '-' is prepended to the first >

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-07 Thread Costas Argyris via Gcc-patches
Problem: gcc-ar fails when a @file is passed to it: $ cat rsp --version $ gcc-ar @rsp /usr/bin/ar: invalid option -- '@' This is because a dash '-' is prepended to the first argument if it doesn't start with one, resulting in the wrong call 'ar -@rsp'. Fix: Expand argv to get rid of any @files

Re: [PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-03 Thread Costas Argyris via Gcc-patches
I should also add that for a rsp file that contains just "--version": gcc-ar @rsp fails without the patch (current problem) and successfully prints the version info with it. On Sat, 1 Jul 2023 at 22:45, Costas Argyris wrote: > Basically implementing what Andrew said in the PR: > >

[PATCH] gcc-ar: Handle response files properly [PR77576]

2023-07-01 Thread Costas Argyris via Gcc-patches
Basically implementing what Andrew said in the PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77576 If @file has been passed to gcc-ar, do the following: 1) Expand it to get an argv without any @files. 2) Then apply the plugin modifications to argv. 3) Create temporary response file. 4) Put