Re: [PATCH] gcov: Configurable destination for error output

2016-02-23 Thread Nathan Sidwell
On 02/23/16 11:04, Aaron Conole wrote: Before I start cooking up this change, is it possible I need to worry about gcov_error being invoked from multiple threads? If so, I'll need some kind of mutex which I think is not needed with the current design. As I recall the main entry points to the

Re: [PATCH] gcov: Configurable destination for error output

2016-02-23 Thread Aaron Conole
Nathan Sidwell writes: > On 02/22/16 14:35, Aaron Conole wrote: > >> D'oh, you're probably right. In my excitement to contribute, I forgot >> this was shared. I think 'w' should be correct, since this isn't >> intended to be read at all, but I could be convinced

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 14:35, Aaron Conole wrote: D'oh, you're probably right. In my excitement to contribute, I forgot this was shared. I think 'w' should be correct, since this isn't intended to be read at all, but I could be convinced otherwise. sorry, I misremembered the encoding of write append,

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Aaron Conole writes: > Nathan Sidwell writes: > >> On 02/22/16 13:11, Aaron Conole wrote: >>> Nathan Sidwell writes: >>> >>> Hi Nathan, thanks so much for looking at this! >>> On 02/22/16 12:03, Aaron Conole wrote: > The previous

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: > On 02/22/16 13:11, Aaron Conole wrote: >> Nathan Sidwell writes: >> >> Hi Nathan, thanks so much for looking at this! >> >>> On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 13:11, Aaron Conole wrote: Nathan Sidwell writes: Hi Nathan, thanks so much for looking at this! On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: Hi Nathan, thanks so much for looking at this! > On 02/22/16 12:03, Aaron Conole wrote: >> The previous gcov behavior was to always output errors on the stderr channel. >> This is fine for most uses, but some programs will require stderr to be >> silent

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Nathan Sidwell
On 02/22/16 12:03, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be silent for certain tests. This change allows configuring the gcov output by an environment variable which

[PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be silent for certain tests. This change allows configuring the gcov output by an environment variable which will be used to open the appropriate file.