Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread H.J. Lu
>> >> >> Fixed. >> >> >> >> >> >> -- >> >> >> H.J. >> >> > >> >> >> From f08b8721ed038cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00 2001 >> >> >> From: "H.J. Lu" >

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread Jan Hubicka
gt;> PR target/r84530 > >> >> > > >> >> > Just a nit I've noticed: > >> >> > > >> >> > s/r84530/84530 > >> >> > >> >> Fixed. > >> >> > >> >> -- > >> &

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread H.J. Lu
rget/r84530 >> >> > >> >> > Just a nit I've noticed: >> >> > >> >> > s/r84530/84530 >> >> >> >> Fixed. >> >> >> >> -- >> >> H.J. >> > >> >> From f08b8721ed

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread Jan Hubicka
> >> > > >> > s/r84530/84530 > >> > >> Fixed. > >> > >> -- > >> H.J. > > > >> From f08b8721ed038cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00 2001 > >> From: "H.J. Lu" > >> Date: Sat, 2

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread H.J. Lu
>> > s/r84530/84530 >> >> Fixed. >> >> -- >> H.J. > >> From f08b8721ed038cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00 2001 >> From: "H.J. Lu" >> Date: Sat, 24 Feb 2018 05:05:49 -0800 >> Subject: [PATCH] i386: Update -mfunction-retur

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread Jan Hubicka
cefcee5a0bb1329b90a2d322269 Mon Sep 17 00:00:00 2001 > From: "H.J. Lu" > Date: Sat, 24 Feb 2018 05:05:49 -0800 > Subject: [PATCH] i386: Update -mfunction-return= for return with pop > > When -mfunction-return= is used, simple_return_pop_internal should pop > return addr

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread H.J. Lu
.J. Lu" Date: Sat, 24 Feb 2018 05:05:49 -0800 Subject: [PATCH] i386: Update -mfunction-return= for return with pop When -mfunction-return= is used, simple_return_pop_internal should pop return address into ECX register, adjust stack by bytes to pop from stack and jump to the return thunk via E

Re: [PATCH] i386: Update -mfunction-return= for return with pop

2018-02-26 Thread Martin Liška
On 02/25/2018 02:37 AM, H.J. Lu wrote: > PR target/r84530 Just a nit I've noticed: s/r84530/84530 Martin

[PATCH] i386: Update -mfunction-return= for return with pop

2018-02-24 Thread H.J. Lu
When -mfunction-return= is used, simple_return_pop_internal should pop return address into ECX register, adjust stack by bytes to pop from stack and jump to the return thunk via ECX register. Tested on i686 and x86-64. PR target/r84530 * config/i386/i386-protos.h (ix86_output_indi