Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-08 Thread Jan Hubicka
> > Thanks. So caller could be {hot, cold} + {large, small}, same for callee. > It may > produce up to 4 * 4 = 16 combinations. Agree that hard to define useful, > and useful really doesn't reflect performance improvements certainly. :) > > My case is A1(1) calls A2(2), A2(2) calls A3(3).

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-07 Thread luoxhu
On 2020/1/7 23:40, Jan Hubicka wrote: >> >> >> On 2020/1/7 16:40, Jan Hubicka wrote: On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: > Inline should return failure either (newsize > param_large_function_insns) > OR (newsize > limit). Sometimes newsize is larger than >

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-07 Thread Jan Hubicka
> > > On 2020/1/7 16:40, Jan Hubicka wrote: > >> On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: > >>> Inline should return failure either (newsize > param_large_function_insns) > >>> OR (newsize > limit). Sometimes newsize is larger than > >>> param_large_function_insns, but smaller

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-07 Thread luoxhu
On 2020/1/7 16:40, Jan Hubicka wrote: >> On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: >>> Inline should return failure either (newsize > param_large_function_insns) >>> OR (newsize > limit). Sometimes newsize is larger than >>> param_large_function_insns, but smaller than limit,

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-07 Thread Martin Liška
On 1/7/20 9:40 AM, Jan Hubicka wrote: On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: Inline should return failure either (newsize > param_large_function_insns) OR (newsize > limit). Sometimes newsize is larger than param_large_function_insns, but smaller than limit, inline doesn't

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-07 Thread Jan Hubicka
> On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: > > Inline should return failure either (newsize > param_large_function_insns) > > OR (newsize > limit). Sometimes newsize is larger than > > param_large_function_insns, but smaller than limit, inline doesn't return > > failure even if the

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-06 Thread luoxhu
On 2020/1/7 02:01, Jeff Law wrote: On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: Inline should return failure either (newsize > param_large_function_insns) OR (newsize > limit). Sometimes newsize is larger than param_large_function_insns, but smaller than limit, inline doesn't return

Re: [PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-06 Thread Jeff Law
On Mon, 2020-01-06 at 01:03 -0600, Xiong Hu Luo wrote: > Inline should return failure either (newsize > param_large_function_insns) > OR (newsize > limit). Sometimes newsize is larger than > param_large_function_insns, but smaller than limit, inline doesn't return > failure even if the new

[PATCH] ipa-inline: Adjust condition for caller_growth_limits

2020-01-05 Thread Xiong Hu Luo
Inline should return failure either (newsize > param_large_function_insns) OR (newsize > limit). Sometimes newsize is larger than param_large_function_insns, but smaller than limit, inline doesn't return failure even if the new function is a large function. Therefore, param_large_function_insns