Re: [PATCH] libiberty: Use posix_spawn in pex-unix when available.

2023-10-02 Thread Ian Lance Taylor
On Fri, Sep 29, 2023 at 12:18 PM Brendan Shanks wrote: > > + #define ERR_ON_FAILURE(ret, func) \ > +do { if (ret) { *err = ret; *errmsg = func; goto exit; } else {} } while > (0) Thanks, but please don't use a macro that changes control flow. Ian

[PATCH] libiberty: Use posix_spawn in pex-unix when available.

2023-09-29 Thread Brendan Shanks
Hi, This patch implements pex_unix_exec_child using posix_spawn when available. This should especially benefit recent macOS (where vfork just calls fork), but should have equivalent or faster performance on all platforms. In addition, the implementation is substantially simpler than the