Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-26 Thread Jonathan Wakely via Gcc-patches
On 25/11/20 18:39 +, Jonathan Wakely wrote: On 25/11/20 10:35 +, Jonathan Wakely wrote: I've pushed that as ad9cbcee543ecccd79fa49dafcd925532d2ce210 but there are still other FAILs to be fixed. I think the other FAILs are due to a race condition in the tests, fixed by this patch.

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-25 Thread Jonathan Wakely via Gcc-patches
On 25/11/20 10:35 +, Jonathan Wakely wrote: I've pushed that as ad9cbcee543ecccd79fa49dafcd925532d2ce210 but there are still other FAILs to be fixed. I think the other FAILs are due to a race condition in the tests, fixed by this patch. Tested x86_64-linux, powerpc64le-linux,

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-25 Thread Jonathan Wakely via Gcc-patches
On 25/11/20 10:35 +, Jonathan Wakely wrote: On 25/11/20 01:07 +, Jonathan Wakely wrote: On 24/11/20 23:45 +, Jonathan Wakely wrote: On 21/11/20 16:36 -0800, H.J. Lu wrote: On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: On 21/11/20 17:04 +, Jonathan

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-25 Thread Jonathan Wakely via Gcc-patches
On 25/11/20 01:07 +, Jonathan Wakely wrote: On 24/11/20 23:45 +, Jonathan Wakely wrote: On 21/11/20 16:36 -0800, H.J. Lu wrote: On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: On 21/11/20 17:04 +, Jonathan Wakely wrote: On 21/11/20 16:16 +0100, Andreas

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-24 Thread Jonathan Wakely via Gcc-patches
On 24/11/20 23:45 +, Jonathan Wakely wrote: On 21/11/20 16:36 -0800, H.J. Lu wrote: On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: On 21/11/20 17:04 +, Jonathan Wakely wrote: On 21/11/20 16:16 +0100, Andreas Schwab wrote: In file included from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-24 Thread Jonathan Wakely via Gcc-patches
On 21/11/20 16:36 -0800, H.J. Lu wrote: On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: On 21/11/20 17:04 +, Jonathan Wakely wrote: >On 21/11/20 16:16 +0100, Andreas Schwab wrote: >>In file included from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread David Edelsohn via Gcc-patches
On Mon, Nov 23, 2020 at 1:31 PM Jonathan Wakely wrote: > > On 22/11/20 13:37 +, Jonathan Wakely via Libstdc++ wrote: > >On Sun, 22 Nov 2020, 12:29 Iain Sandoe, wrote: > > > >> thanks for looking at this over the weekend. > >> > >> Jonathan Wakely via Gcc-patches wrote: > >> > >> > On Sat,

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 22/11/20 22:13 +0100, Stephan Bergmann wrote: On 20/11/2020 23:44, Thomas Rodgers wrote: Tested x86_64-pc-linux-gnu, committed. Clang complains: $ cat test.cc #include $ clang++ --gcc-toolchain=~/gcc/trunk/inst -std=c++20 -fsyntax-only test.cc In file included from test.cc:1: In file

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 22/11/20 22:41 +0100, Stephan Bergmann wrote: On 20/11/2020 23:44, Thomas Rodgers wrote: Tested x86_64-pc-linux-gnu, committed. ...and there are multiple definition complaints from the linker because of two missing "include": index 7b2682a577e..23ab2018ca8 100644 ---

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 23/11/20 18:31 +, Jonathan Wakely wrote: On 22/11/20 13:37 +, Jonathan Wakely via Libstdc++ wrote: On Sun, 22 Nov 2020, 12:29 Iain Sandoe, wrote: thanks for looking at this over the weekend. Jonathan Wakely via Gcc-patches wrote: On Sat, 21 Nov 2020 at 23:55, David Edelsohn

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 22/11/20 13:37 +, Jonathan Wakely via Libstdc++ wrote: On Sun, 22 Nov 2020, 12:29 Iain Sandoe, wrote: thanks for looking at this over the weekend. Jonathan Wakely via Gcc-patches wrote: > On Sat, 21 Nov 2020 at 23:55, David Edelsohn via Libstdc++ > wrote: >> I am seeing 93 new

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 22/11/20 01:27 +, Jonathan Wakely via Libstdc++ wrote: On Sat, 21 Nov 2020 at 23:55, David Edelsohn via Libstdc++ wrote: I am seeing 93 new libstdc++ failures on AIX, even after Jonathan's fixes. And a few c++ failures with similar symptoms. I'm not certain that it is due to this

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 21/11/20 17:39 +, Jonathan Wakely wrote: On 21/11/20 17:04 +, Jonathan Wakely wrote: On 21/11/20 16:16 +0100, Andreas Schwab wrote: In file included from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-23 Thread Jonathan Wakely via Gcc-patches
On 21/11/20 16:36 -0800, H.J. Lu wrote: On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: On 21/11/20 17:04 +, Jonathan Wakely wrote: >On 21/11/20 16:16 +0100, Andreas Schwab wrote: >>In file included from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-22 Thread Stephan Bergmann via Gcc-patches
On 20/11/2020 23:44, Thomas Rodgers wrote: Tested x86_64-pc-linux-gnu, committed. ...and there are multiple definition complaints from the linker because of two missing "include": index 7b2682a577e..23ab2018ca8 100644 --- a/libstdc++-v3/include/bits/atomic_wait.h +++

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-22 Thread Stephan Bergmann via Gcc-patches
On 20/11/2020 23:44, Thomas Rodgers wrote: Tested x86_64-pc-linux-gnu, committed. Clang complains: $ cat test.cc #include $ clang++ --gcc-toolchain=~/gcc/trunk/inst -std=c++20 -fsyntax-only test.cc In file included from test.cc:1: In file included from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-22 Thread Jonathan Wakely via Gcc-patches
On Sun, 22 Nov 2020, 12:29 Iain Sandoe, wrote: > thanks for looking at this over the weekend. > > Jonathan Wakely via Gcc-patches wrote: > > > On Sat, 21 Nov 2020 at 23:55, David Edelsohn via Libstdc++ > > wrote: > >> I am seeing 93 new libstdc++ failures on AIX, even after Jonathan's > >>

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-22 Thread Iain Sandoe via Gcc-patches
thanks for looking at this over the weekend. Jonathan Wakely via Gcc-patches wrote: On Sat, 21 Nov 2020 at 23:55, David Edelsohn via Libstdc++ wrote: I am seeing 93 new libstdc++ failures on AIX, even after Jonathan's fixes. And a few c++ failures with similar symptoms. I'm not certain

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread Jonathan Wakely via Gcc-patches
On Sat, 21 Nov 2020 at 23:55, David Edelsohn via Libstdc++ wrote: > > I am seeing 93 new libstdc++ failures on AIX, even after Jonathan's > fixes. And a few c++ failures with similar symptoms. I'm not certain > that it is due to this patch, but it's the likely suspect. Yes, it's that patch.

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread H.J. Lu via Gcc-patches
On Sat, Nov 21, 2020 at 9:40 AM Jonathan Wakely via Gcc-patches wrote: > > On 21/11/20 17:04 +, Jonathan Wakely wrote: > >On 21/11/20 16:16 +0100, Andreas Schwab wrote: > >>In file included from >

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread David Edelsohn via Gcc-patches
I am seeing 93 new libstdc++ failures on AIX, even after Jonathan's fixes. And a few c++ failures with similar symptoms. I'm not certain that it is due to this patch, but it's the likely suspect. FAIL: 17_intro/headers/c++2020/all_attributes.cc (test for excess errors) FAIL:

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread Jonathan Wakely via Gcc-patches
On 21/11/20 17:04 +, Jonathan Wakely wrote: On 21/11/20 16:16 +0100, Andreas Schwab wrote: In file included from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread Jonathan Wakely via Gcc-patches
On 21/11/20 16:16 +0100, Andreas Schwab wrote: In file included from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/memory:78, from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-21 Thread Andreas Schwab
In file included from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/bits/shared_ptr_atomic.h:33, from /daten/aranym/gcc/gcc-20201121/Build/m68k-linux/libstdc++-v3/include/memory:78, from

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-11-20 Thread Thomas Rodgers
Tested x86_64-pc-linux-gnu, committed. > On Oct 27, 2020, at 3:23 AM, Jonathan Wakely wrote: > > On 26/10/20 14:48 -0700, Thomas Rodgers wrote: >> +#include >> + >> +#if __has_include() >> +#define _GLIBCXX_HAVE_POSIX_SEMAPHORE 1 >> +#include > > It occurs to me now that this check probably

Re: [PATCH] libstdc++: Add c++2a

2020-11-03 Thread Jonathan Wakely via Gcc-patches
On 03/11/20 22:22 +0100, Christophe Lyon via Libstdc++ wrote: On Mon, 2 Nov 2020 at 19:43, Thomas Rodgers via Gcc-patches wrote: Testsed x86_64-pc-linux-gnu, committed to master. Hi, I can see the new tests failing on bare-metal targets using newlib (arm-eabi, aarch64-elf):

Re: [PATCH] libstdc++: Add c++2a

2020-11-03 Thread Christophe Lyon via Gcc-patches
On Mon, 2 Nov 2020 at 19:43, Thomas Rodgers via Gcc-patches wrote: > > > Testsed x86_64-pc-linux-gnu, committed to master. > Hi, I can see the new tests failing on bare-metal targets using newlib (arm-eabi, aarch64-elf): 27_io/basic_syncbuf/1.cc (test for excess errors)

Re: [PATCH] libstdc++: Add c++2a

2020-11-02 Thread Thomas Rodgers via Gcc-patches
Testsed x86_64-pc-linux-gnu, committed to master. Jonathan Wakely writes: > On 02/11/20 08:10 -0800, Thomas Rodgers wrote: >>From: Thomas Rodgers >> >>IGNORE the previous patch. >> >>Changes implementation to use a private __mutex type as discussed on >>IRC. >> >>libstdc++/ChangeLog: >>

Re: [PATCH] libstdc++: Add c++2a

2020-11-02 Thread Jonathan Wakely via Gcc-patches
On 02/11/20 08:10 -0800, Thomas Rodgers wrote: From: Thomas Rodgers IGNORE the previous patch. Changes implementation to use a private __mutex type as discussed on IRC. libstdc++/ChangeLog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header.

[PATCH] libstdc++: Add c++2a

2020-11-02 Thread Thomas Rodgers
From: Thomas Rodgers IGNORE the previous patch. Changes implementation to use a private __mutex type as discussed on IRC. libstdc++/ChangeLog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header.

[PATCH] libstdc++: Add c++2a

2020-11-02 Thread Thomas Rodgers
From: Thomas Rodgers Changes implementation to use a private __mutex type as discussed on IRC. libstdc++/ChangeLog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header.

[PATCH] libstdc++: Add c++2a

2020-10-29 Thread Thomas Rodgers
From: Thomas Rodgers Addresses latest patch feedback. Changes to also work on single threaded configurations. libstdc++/ChangeLog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header.

Re: [PATCH] libstdc++: Add c++2a

2020-10-29 Thread Jonathan Wakely via Gcc-patches
On 21/10/20 09:53 -0700, Thomas Rodgers wrote: From: Thomas Rodgers libstdc++/Changelog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate.

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-10-27 Thread Jonathan Wakely via Gcc-patches
On 26/10/20 14:48 -0700, Thomas Rodgers wrote: +#include + +#if __has_include() +#define _GLIBCXX_HAVE_POSIX_SEMAPHORE 1 +#include It occurs to me now that this check probably isn't robust enough. For any POSIX system it's probably safe to assume that means the POSIX header and so sem_t is

[PATCH] libstdc++: Add C++2a synchronization support

2020-10-26 Thread Thomas Rodgers
From: Thomas Rodgers Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_one/notify_all * counting_semaphore * binary_semaphore * latch libstdc++-v3/ChangeLog: * include/Makefile.am (bits_headers): Add new header. * include/Makefile.in:

Re: [PATCH] libstdc++: Add c++2a

2020-10-21 Thread Thomas Rodgers
> On Oct 21, 2020, at 10:34 AM, Jonathan Wakely wrote: > > On 21/10/20 09:53 -0700, Thomas Rodgers wrote: >> From: Thomas Rodgers >> >> libstdc++/Changelog: >> libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. >> libstdc++-v3/include/Makefile.am (std_headers): Add new

Re: [PATCH] libstdc++: Add c++2a

2020-10-21 Thread Jonathan Wakely via Gcc-patches
On 21/10/20 09:53 -0700, Thomas Rodgers wrote: From: Thomas Rodgers libstdc++/Changelog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate.

[PATCH] libstdc++: Add c++2a

2020-10-21 Thread Thomas Rodgers
From: Thomas Rodgers libstdc++/Changelog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate. libstdc++-v3/include/precompiled/stdc++.h: Include

[PATCH] libstdc++: Add c++2a

2020-10-15 Thread Thomas Rodgers
From: Thomas Rodgers This should address the cumulative comments (modulo the discussion going on on the reflector about specification issues/questions). libstdc++/Changelog: libstdc++-v3/doc/doxygen/user.cfg.in (INPUT): Add new header. libstdc++-v3/include/Makefile.am

Re: [PATCH] libstdc++: Add c++2a

2020-10-15 Thread Jonathan Wakely via Gcc-patches
On 15/10/20 07:46 -0700, Thomas Rodgers wrote: + template , + typename _Alloc = allocator<_CharT>> +class basic_osyncstream : public basic_ostream<_CharT, _Traits> +{ +public: + // Types: + using char_type = _CharT; + using traits_type = _Traits; +

Re: [PATCH] libstdc++: Add c++2a

2020-10-15 Thread Jonathan Wakely via Gcc-patches
On 15/10/20 07:46 -0700, Thomas Rodgers wrote: From: Thomas Rodgers * Note: depends on a sufficiently C++20ified basic_stringbuf<>. libstdc++/Changelog: libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate.

Re: [PATCH] libstdc++: Add c++2a

2020-10-15 Thread Jonathan Wakely via Gcc-patches
On 15/10/20 07:46 -0700, Thomas Rodgers wrote: From: Thomas Rodgers * Note: depends on a sufficiently C++20ified basic_stringbuf<>. libstdc++/Changelog: libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate.

[PATCH] libstdc++: Add c++2a

2020-10-15 Thread Thomas Rodgers
From: Thomas Rodgers * Note: depends on a sufficiently C++20ified basic_stringbuf<>. libstdc++/Changelog: libstdc++-v3/include/Makefile.am (std_headers): Add new header. libstdc++-v3/include/Makefile.in: Regenerate. libstdc++-v3/include/std/streambuf

[PATCH] libstdc++: Add C++2a synchronization support

2020-10-02 Thread Thomas Rodgers
From: Thomas Rodgers Updated patch incorporating latest feedback (revised). Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_one/notify_all * counting_semaphore * binary_semaphore * latch libstdc++-v3/ChangeLog: * include/Makefile.am

[PATCH] libstdc++: Add C++2a synchronization support

2020-10-01 Thread Thomas Rodgers
From: Thomas Rodgers Updated patch incorporating latest feedback. Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_one/notify_all * counting_semaphore * binary_semaphore * latch libstdc++-v3/ChangeLog: * include/Makefile.am (bits_headers):

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-29 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 14:29 -0700, Thomas Rodgers wrote: +template + __atomic_wait_status + __platform_wait_until_impl(__platform_wait_t* __addr, +__platform_wait_t __val, +const chrono::time_point<__platform_wait_clock_t, +

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Thomas Rodgers via Gcc-patches
Jonathan Wakely writes: > On 11/09/20 16:58 -0700, Thomas Rodgers wrote: >>From: Thomas Rodgers >> >>This patch supercedes both the Add C++2a synchronization support patch >>being replied to *and* the patch adding wait/notify_* to atomic_flag. >> >>Add support for - >> *

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all *

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all *

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all *

[PATCH] libstdc++: Add C++2a synchronization support

2020-09-11 Thread Thomas Rodgers
From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_one/notify_all * counting_semaphore *