Re: [PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Jonathan Wakely
This should do the same changes for std::insert_iterator, but it currently crashes the compiler (PR 93907). I am not committing this yet. commit 2db20402125e6136d6768598f5974e917b2622c6 Author: Jonathan Wakely Date: Mon Feb 24 15:50:59 2020 + libstdc++: Add missing bits of P0896R4

Re: [PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Jonathan Wakely
On 24/02/20 08:53 -0500, Patrick Palka wrote: On Mon, 24 Feb 2020, Jonathan Wakely wrote: On 24/02/20 08:29 -0500, Patrick Palka wrote: > This adds some missing pieces of the Ranges TS that make > back_insert_iterator and > front_insert_iterator conform to the new output_iterator requirements.

Re: [PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Patrick Palka
On Mon, 24 Feb 2020, Jonathan Wakely wrote: > On 24/02/20 08:29 -0500, Patrick Palka wrote: > > This adds some missing pieces of the Ranges TS that make > > back_insert_iterator and > > front_insert_iterator conform to the new output_iterator requirements. > > > > It also fixes a bug in

Re: [PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Jonathan Wakely
On 24/02/20 08:29 -0500, Patrick Palka wrote: This adds some missing pieces of the Ranges TS that make back_insert_iterator and front_insert_iterator conform to the new output_iterator requirements. It also fixes a bug in ranges::__copy_or_move and ranges::__copy_or_move_backward in which we

Re: [PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Patrick Palka
ZOn Mon, 24 Feb 2020, Patrick Palka wrote: > This adds some missing pieces of the Ranges TS that make back_insert_iterator > and > front_insert_iterator conform to the new output_iterator requirements. > > It also fixes a bug in ranges::__copy_or_move and > ranges::__copy_or_move_backward in

[PATCH] libstdc++: Add missing bits of P0896R4 pertaining to [back|front]_insert_iterator

2020-02-24 Thread Patrick Palka
This adds some missing pieces of the Ranges TS that make back_insert_iterator and front_insert_iterator conform to the new output_iterator requirements. It also fixes a bug in ranges::__copy_or_move and ranges::__copy_or_move_backward in which we were inspecting the iter_value_t of the output