Re: [PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-07-10 Thread Jonathan Wakely via Gcc-patches
On Wed, 28 Jun 2023 at 08:56, Jan Hubicka wrote: > > > I think the __throw_bad_alloc() and __throw_bad_array_new_length() > > functions should always be rare, so marking them cold seems fine (users who > > define their own allocators that want to throw bad_alloc "often" will > > probably throw it

Re: [PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-06-28 Thread Jonathan Wakely via Gcc-patches
On Wed, 28 Jun 2023 at 08:56, Jan Hubicka wrote: > > I think the __throw_bad_alloc() and __throw_bad_array_new_length() > > functions should always be rare, so marking them cold seems fine (users > who > > define their own allocators that want to throw bad_alloc "often" will > > probably throw it

Re: [PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-06-28 Thread Jan Hubicka via Gcc-patches
> I think the __throw_bad_alloc() and __throw_bad_array_new_length() > functions should always be rare, so marking them cold seems fine (users who > define their own allocators that want to throw bad_alloc "often" will > probably throw it directly, they shouldn't be using our __throw_bad_alloc() >

Re: [PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-06-23 Thread Jonathan Wakely via Gcc-patches
On Fri, 23 Jun 2023 at 17:44, Jan Hubicka wrote: > > I intend to push this to trunk once testing finishes. > > > > I generated the diff with -b so the whitespace changes aren't shown, > > because there was some re-indenting that makes the diff look larger than > > it really is. > > > > Honza, I

Re: [PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-06-23 Thread Jan Hubicka via Gcc-patches
> I intend to push this to trunk once testing finishes. > > I generated the diff with -b so the whitespace changes aren't shown, > because there was some re-indenting that makes the diff look larger than > it really is. > > Honza, I don't think this is likely to make much difference for the PR >

[PATCH] libstdc++: Use RAII in std::vector::_M_realloc_insert

2023-06-20 Thread Jonathan Wakely via Gcc-patches
I intend to push this to trunk once testing finishes. I generated the diff with -b so the whitespace changes aren't shown, because there was some re-indenting that makes the diff look larger than it really is. Honza, I don't think this is likely to make much difference for the PR 110287