Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-08-01 Thread Jonathan Wakely
On 30/07/14 23:36 +0800, Zifei Tong wrote: On Wed, Jul 30, 2014 at 11:25 PM, Jonathan Wakely jwak...@redhat.com wrote: On 30/07/14 22:42 +0800, Zifei Tong wrote: Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc

[PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Zifei Tong
Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_thread_atexit_impl implemented. It turns out that the code tried to use macro HAVE___CXA_THREAD_ATEXIT_IMPL, but not

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Jonathan Wakely
On 30/07/14 22:42 +0800, Zifei Tong wrote: Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_thread_atexit_impl implemented. It turns out that the code tried to use macro

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Zifei Tong
On Wed, Jul 30, 2014 at 11:25 PM, Jonathan Wakely jwak...@redhat.com wrote: On 30/07/14 22:42 +0800, Zifei Tong wrote: Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_thread_atexit_impl

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-07-30 Thread Jason Merrill
On 07/30/2014 11:25 AM, Jonathan Wakely wrote: Jason, any objection to putting this on the 4.8 and 4.9 branches too? That should be OK. Jason