Re: [PATCH] libstdc++: testsuite: Simplify codecvt_unicode

2023-01-18 Thread Jonathan Wakely via Gcc-patches
On Wed, 18 Jan 2023 at 19:52, Dimitrij Mijoski wrote: > > On Wed, 2023-01-18 at 18:53 +, Jonathan Wakely wrote: > > This doesn't compile in C++11 or C++14, because there's no guaranteed > > elision. > > I see. I just looked up in the docs and found that I need to put >

Re: [PATCH] libstdc++: testsuite: Simplify codecvt_unicode

2023-01-18 Thread Dimitrij Mijoski via Gcc-patches
On Wed, 2023-01-18 at 18:53 +, Jonathan Wakely wrote: > This doesn't compile in C++11 or C++14, because there's no guaranteed > elision. I see. I just looked up in the docs and found that I need to put --target_board=unix/-std=c++11 inside RUNTESTFLAGS to test in C++11 mode.

Re: [PATCH] libstdc++: testsuite: Simplify codecvt_unicode

2023-01-18 Thread Jonathan Wakely via Gcc-patches
On 17/01/23 22:12 +0100, Dimitrij Mijoski wrote: Stop using unique_ptr, create some objects directly. libstdc++-v3/ChangeLog: * testsuite/22_locale/codecvt/codecvt_unicode.cc: Simplify. * testsuite/22_locale/codecvt/codecvt_unicode.h: Simplify. *

Re: [PATCH] libstdc++: testsuite: Simplify codecvt_unicode

2023-01-17 Thread Jonathan Wakely via Gcc-patches
On Tue, 17 Jan 2023, 21:12 Dimitrij Mijoski via Libstdc++, < libstd...@gcc.gnu.org> wrote: > Stop using unique_ptr, create some objects directly. > Thanks, I thought about suggesting this, but decided it was good enough. But I'm glad to see the simplifications :-) I'll get this committed. >

[PATCH] libstdc++: testsuite: Simplify codecvt_unicode

2023-01-17 Thread Dimitrij Mijoski via Gcc-patches
Stop using unique_ptr, create some objects directly. libstdc++-v3/ChangeLog: * testsuite/22_locale/codecvt/codecvt_unicode.cc: Simplify. * testsuite/22_locale/codecvt/codecvt_unicode.h: Simplify. * testsuite/22_locale/codecvt/codecvt_unicode_wchar_t.cc: Simplify. ---