Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-23 Thread Alexandre Oliva via Gcc-patches
On Jun 23, 2022, Jonathan Wakely wrote: >> Regstrapped on x86_64-linux-gnu, also tested with a cross to >> aarch64-rtems6. Ok to install? > OK, thanks. Sorry, I failed to refresh this one too. Here's what I'm going to install: libstdc++: xfail rename tests on rtems From: Alexandre Oliva

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-23 Thread Jonathan Wakely via Gcc-patches
On Thu, 23 Jun 2022 at 12:21, Alexandre Oliva wrote: > > On Jun 23, 2022, Jonathan Wakely wrote: > > > On Thu, 23 Jun 2022 at 07:26, Alexandre Oliva wrote: > >> Would a patch to add: > >> > >> // { dg-xfail-if "::rename is not POSIX-compliant" { target *-*-rtems* } } > >> > >> to rename.cc tests

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-23 Thread Alexandre Oliva via Gcc-patches
On Jun 23, 2022, Jonathan Wakely wrote: > On Thu, 23 Jun 2022 at 07:26, Alexandre Oliva wrote: >> Would a patch to add: >> >> // { dg-xfail-if "::rename is not POSIX-compliant" { target *-*-rtems* } } >> >> to rename.cc tests be acceptable? > Yes, I think that's definitely the way to go. The

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-23 Thread Jonathan Wakely via Gcc-patches
On Thu, 23 Jun 2022 at 07:26, Alexandre Oliva wrote: > This feels more and more like a case for xfail until it gets fixed in > the kernel, where atomic filesystem operations belong :-( > > Would a patch to add: > > // { dg-xfail-if "::rename is not POSIX-compliant" { target *-*-rtems* } } > > to

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-23 Thread Alexandre Oliva via Gcc-patches
On Jun 22, 2022, Jonathan Wakely wrote: > "If the old argument and the new argument resolve to either the same > existing directory entry or different directory entries for the same > existing file, rename() shall return successfully and perform no other > action." and "If the link named by the

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-22 Thread Alexandre Oliva via Gcc-patches
On Jun 22, 2022, Jonathan Wakely wrote: > On Wed, 22 Jun 2022 at 08:02, Alexandre Oliva via Libstdc++ > wrote: >> >> Hello, Sebastian, >> >> On Jun 22, 2022, Sebastian Huber wrote: >> >> > On 22/06/2022 08:24, Alexandre Oliva via Libstdc++ wrote: >> >> rtems6's rename() implementation

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-22 Thread Jonathan Wakely via Gcc-patches
On Wed, 22 Jun 2022 at 08:02, Alexandre Oliva via Libstdc++ wrote: > > Hello, Sebastian, > > On Jun 22, 2022, Sebastian Huber wrote: > > > On 22/06/2022 08:24, Alexandre Oliva via Libstdc++ wrote: > >> rtems6's rename() implementation errors with EEXIST when the rename-to > >> filename exists,

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-22 Thread Alexandre Oliva via Gcc-patches
Hello, Sebastian, On Jun 22, 2022, Sebastian Huber wrote: > On 22/06/2022 08:24, Alexandre Oliva via Libstdc++ wrote: >> rtems6's rename() implementation errors with EEXIST when the rename-to >> filename exists, even when renaming a file to itself or when renaming >> a nonexisting file. Adjust

Re: [PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-22 Thread Sebastian Huber
On 22/06/2022 08:24, Alexandre Oliva via Libstdc++ wrote: rtems6's rename() implementation errors with EEXIST when the rename-to filename exists, even when renaming a file to itself or when renaming a nonexisting file. Adjust expectations. Regstrapped on x86_64-linux-gnu, also tested with a

[PATCH] libstdc++: testsuite: fs rename to self may fail

2022-06-22 Thread Alexandre Oliva via Gcc-patches
rtems6's rename() implementation errors with EEXIST when the rename-to filename exists, even when renaming a file to itself or when renaming a nonexisting file. Adjust expectations. Regstrapped on x86_64-linux-gnu, also tested with a cross to aarch64-rtems6. Ok to install? PS: