Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-18 Thread Christophe Lyon
Hi David, On 15 January 2018 at 11:09, Richard Biener wrote: > On Mon, Jan 8, 2018 at 8:36 PM, David Malcolm wrote: >> On Sat, 2018-01-06 at 08:44 +0100, Richard Biener wrote: >>> On January 5, 2018 11:55:11 PM GMT+01:00, David Malcolm >> hat.com> wrote: >>> > On Fri, 2018-01-05 at 10:36 +0100,

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-15 Thread Richard Biener
On Mon, Jan 8, 2018 at 8:36 PM, David Malcolm wrote: > On Sat, 2018-01-06 at 08:44 +0100, Richard Biener wrote: >> On January 5, 2018 11:55:11 PM GMT+01:00, David Malcolm > hat.com> wrote: >> > On Fri, 2018-01-05 at 10:36 +0100, Richard Biener wrote: >> > > On Thu, Jan 4, 2018 at 10:52 PM, David M

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-08 Thread David Malcolm
On Sat, 2018-01-06 at 08:44 +0100, Richard Biener wrote: > On January 5, 2018 11:55:11 PM GMT+01:00, David Malcolm hat.com> wrote: > > On Fri, 2018-01-05 at 10:36 +0100, Richard Biener wrote: > > > On Thu, Jan 4, 2018 at 10:52 PM, David Malcolm > > om> > > > wrote: > > > > PR lto/83121 reports an

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-05 Thread Richard Biener
On January 5, 2018 11:55:11 PM GMT+01:00, David Malcolm wrote: >On Fri, 2018-01-05 at 10:36 +0100, Richard Biener wrote: >> On Thu, Jan 4, 2018 at 10:52 PM, David Malcolm >> wrote: >> > PR lto/83121 reports an ICE deep inside the linemap code when -Wodr >> > reports on a type mismatch. >> > >>

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-05 Thread David Malcolm
On Fri, 2018-01-05 at 10:36 +0100, Richard Biener wrote: > On Thu, Jan 4, 2018 at 10:52 PM, David Malcolm > wrote: > > PR lto/83121 reports an ICE deep inside the linemap code when -Wodr > > reports on a type mismatch. > > > > The root cause is that the warning can access the > > DECL_SOURCE_LOCA

Re: [PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-05 Thread Richard Biener
On Thu, Jan 4, 2018 at 10:52 PM, David Malcolm wrote: > PR lto/83121 reports an ICE deep inside the linemap code when -Wodr > reports on a type mismatch. > > The root cause is that the warning can access the DECL_SOURCE_LOCATION > of a streamed-in decl before the lto_location_cache has been applie

[PATCH] lto, testsuite: Fix ICE in -Wodr (PR lto/83121)

2018-01-04 Thread David Malcolm
PR lto/83121 reports an ICE deep inside the linemap code when -Wodr reports on a type mismatch. The root cause is that the warning can access the DECL_SOURCE_LOCATION of a streamed-in decl before the lto_location_cache has been applied. lto_location_cache::input_location stores RESERVED_LOCATION_