Re: [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-22 Thread Segher Boessenkool
On Wed, Dec 21, 2022 at 11:41:58AM +0800, Kewen.Lin wrote: > on 2022/12/20 21:19, Segher Boessenkool wrote: > > Sure, I understand that. What I don't like is the generator program is > > much too big and unstructured already, and this doesn't help at all; it > > makes it quite a bit worse even.

Re: [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-20 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2022/12/20 21:19, Segher Boessenkool wrote: > Hi! > > On Mon, Dec 19, 2022 at 02:13:49PM +0800, Kewen.Lin wrote: >> on 2022/12/15 06:29, Segher Boessenkool wrote: >>> On Wed, Nov 30, 2022 at 04:30:13PM +0800, Kewen.Lin wrote: --- a/gcc/config/rs6000/genfusion.pl +++

Re: [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-20 Thread Segher Boessenkool
Hi! On Mon, Dec 19, 2022 at 02:13:49PM +0800, Kewen.Lin wrote: > on 2022/12/15 06:29, Segher Boessenkool wrote: > > On Wed, Nov 30, 2022 at 04:30:13PM +0800, Kewen.Lin wrote: > >> --- a/gcc/config/rs6000/genfusion.pl > >> +++ b/gcc/config/rs6000/genfusion.pl > >> @@ -167,7 +167,7 @@ sub

Re: [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-19 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the review comments! on 2022/12/15 06:29, Segher Boessenkool wrote: > On Wed, Nov 30, 2022 at 04:30:13PM +0800, Kewen.Lin wrote: >> As PR104024 shows, the option -mpower10-fusion isn't guarded by >> -mcpu=power10, it causes compiler to fuse for some patterns >> even without

Re: [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-14 Thread Segher Boessenkool
On Wed, Nov 30, 2022 at 04:30:13PM +0800, Kewen.Lin wrote: > As PR104024 shows, the option -mpower10-fusion isn't guarded by > -mcpu=power10, it causes compiler to fuse for some patterns > even without power10 support and then causes ICE unexpectedly, > this patch is to simply unmask it without

PING^1 [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-12-14 Thread Kewen.Lin via Gcc-patches
Hi, Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607526.html BR, Kewen on 2022/11/30 16:30, Kewen.Lin via Gcc-patches wrote: > Hi, > > As PR104024 shows, the option -mpower10-fusion isn't guarded by > -mcpu=power10, it causes compiler to fuse for some patterns > even

[PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-11-30 Thread Kewen.Lin via Gcc-patches
Hi, As PR104024 shows, the option -mpower10-fusion isn't guarded by -mcpu=power10, it causes compiler to fuse for some patterns even without power10 support and then causes ICE unexpectedly, this patch is to simply unmask it without power10 support, not emit any warnings as this option is

PING^1 [PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-03-15 Thread Kewen.Lin via Gcc-patches
Hi, Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590692.html BR, Kewen on 2022/2/22 10:47 AM, Kewen.Lin via Gcc-patches wrote: > Hi, > > As PR104024 shows, currently the option -mpower10-fusion isn't guarded > under -mcpu=power10, so compiler can optimize some patterns

[PATCH] rs6000: Fix some issues related to Power10 fusion [PR104024]

2022-02-21 Thread Kewen.Lin via Gcc-patches
Hi, As PR104024 shows, currently the option -mpower10-fusion isn't guarded under -mcpu=power10, so compiler can optimize some patterns unexpectedly. As the option is undocumented, this patch just simply unmasks it. For some define_insns in fusion.md which have constraint v, they don't have the