Re: [PATCH] rs6000: Fix the shift patterns, and add test

2014-07-03 Thread David Edelsohn
On Wed, Jul 2, 2014 at 5:06 PM, Segher Boessenkool wrote: > Firstly, it adds back the split conditions that I accidentally removed. > Without it the dot insns are never generated, or rather, always split > back to a separate compare instruction. > > Secondly, the shift amount should be SI always,

[PATCH] rs6000: Fix the shift patterns, and add test

2014-07-02 Thread Segher Boessenkool
Firstly, it adds back the split conditions that I accidentally removed. Without it the dot insns are never generated, or rather, always split back to a separate compare instruction. Secondly, the shift amount should be SI always, not GPR, or GCC will insert a zero-extend at expand time that it can