Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-16 Thread Richard Biener via Gcc-patches
On Wed, Nov 16, 2022 at 3:33 AM Kewen.Lin wrote: > > on 2022/11/10 11:30, Kewen.Lin wrote: > > on 2022/11/9 15:56, Eric Botcazou wrote: > >>> The previous testings on powerpc64{,le}-linux-gnu covered language Go, but > >>> not Ada. I re-tested it with languages c,c++,fortran,objc,obj-c++,go,ada >

Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-15 Thread Kewen.Lin via Gcc-patches
on 2022/11/10 11:30, Kewen.Lin wrote: > on 2022/11/9 15:56, Eric Botcazou wrote: >>> The previous testings on powerpc64{,le}-linux-gnu covered language Go, but >>> not Ada. I re-tested it with languages c,c++,fortran,objc,obj-c++,go,ada >>> on powerpc64le-linux-gnu, the result looked good. Both x

Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-09 Thread Kewen.Lin via Gcc-patches
on 2022/11/9 15:56, Eric Botcazou wrote: >> The previous testings on powerpc64{,le}-linux-gnu covered language Go, but >> not Ada. I re-tested it with languages c,c++,fortran,objc,obj-c++,go,ada >> on powerpc64le-linux-gnu, the result looked good. Both x86 and aarch64 >> cfarm machines which I us

Re: [PATCH] rtl: Try to remove EH edges after {pro, epi}logue generation [PR90259]

2022-11-08 Thread Eric Botcazou via Gcc-patches
> The previous testings on powerpc64{,le}-linux-gnu covered language Go, but > not Ada. I re-tested it with languages c,c++,fortran,objc,obj-c++,go,ada > on powerpc64le-linux-gnu, the result looked good. Both x86 and aarch64 > cfarm machines which I used for testing don't have gnat installed, do

Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-08 Thread Kewen.Lin via Gcc-patches
Hi Richi and Eric, Thanks for your reviews and comments! on 2022/11/8 18:37, Eric Botcazou wrote: >> It looks reasonable - OK if the others CCed have no comments. > > My only comment is that it needs to be tested with languages enabling -fnon- > call-exceptions by default (Ada & Go), if not alre

Re: [PATCH] rtl: Try to remove EH edges after {pro, epi}logue generation [PR90259]

2022-11-08 Thread Eric Botcazou via Gcc-patches
> It looks reasonable - OK if the others CCed have no comments. My only comment is that it needs to be tested with languages enabling -fnon- call-exceptions by default (Ada & Go), if not already done. -- Eric Botcazou

Re: [PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-08 Thread Richard Biener via Gcc-patches
On Tue, Nov 8, 2022 at 3:49 AM Kewen.Lin wrote: > > Hi, > > After prologue and epilogue generation, the judgement on whether > one memory access onto stack frame may trap or not could change, > since we get more exact stack information by now. > > As PR90259 shows, some memory access becomes impos

[PATCH] rtl: Try to remove EH edges after {pro,epi}logue generation [PR90259]

2022-11-07 Thread Kewen.Lin via Gcc-patches
Hi, After prologue and epilogue generation, the judgement on whether one memory access onto stack frame may trap or not could change, since we get more exact stack information by now. As PR90259 shows, some memory access becomes impossible to trap any more after prologue and epilogue generation,