Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-28 Thread Richard Biener
On Tue, Aug 28, 2018 at 4:37 AM Martin Sebor wrote: > > Richard, please let me know if the patch is acceptable as is > (with the RejectNegative property added). As I said, I realize > it's not ideal, but neither is any of the alternatives we have > discussed. They all involve trade- offs, and I

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-27 Thread Martin Sebor
Richard, please let me know if the patch is acceptable as is (with the RejectNegative property added). As I said, I realize it's not ideal, but neither is any of the alternatives we have discussed. They all involve trade- offs, and I think they would all make the behavior of the options less

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-24 Thread Martin Sebor
On 08/24/2018 03:36 AM, Richard Biener wrote: On Fri, Aug 24, 2018 at 12:35 AM Martin Sebor wrote: On 08/23/2018 07:18 AM, Richard Biener wrote: On Thu, Aug 23, 2018 at 12:20 AM Martin Sebor wrote: On 08/20/2018 06:14 AM, Richard Biener wrote: On Thu, Jul 26, 2018 at 10:52 PM Martin

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-24 Thread Richard Biener
On Fri, Aug 24, 2018 at 12:35 AM Martin Sebor wrote: > > On 08/23/2018 07:18 AM, Richard Biener wrote: > > On Thu, Aug 23, 2018 at 12:20 AM Martin Sebor wrote: > >> > >> On 08/20/2018 06:14 AM, Richard Biener wrote: > >>> On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: > > On

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-23 Thread Martin Sebor
On 08/23/2018 07:18 AM, Richard Biener wrote: On Thu, Aug 23, 2018 at 12:20 AM Martin Sebor wrote: On 08/20/2018 06:14 AM, Richard Biener wrote: On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: On 07/26/2018 08:58 AM, Martin Sebor wrote: On 07/26/2018 02:38 AM, Richard Biener wrote:

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-23 Thread Richard Biener
On Thu, Aug 23, 2018 at 12:20 AM Martin Sebor wrote: > > On 08/20/2018 06:14 AM, Richard Biener wrote: > > On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: > >> > >> On 07/26/2018 08:58 AM, Martin Sebor wrote: > >>> On 07/26/2018 02:38 AM, Richard Biener wrote: > On Wed, Jul 25, 2018 at

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-22 Thread Martin Sebor
On 08/20/2018 06:14 AM, Richard Biener wrote: On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: On 07/26/2018 08:58 AM, Martin Sebor wrote: On 07/26/2018 02:38 AM, Richard Biener wrote: On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: On 07/25/2018 08:57 AM, Jakub Jelinek wrote:

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-20 Thread Richard Biener
On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: > > On 07/26/2018 08:58 AM, Martin Sebor wrote: > > On 07/26/2018 02:38 AM, Richard Biener wrote: > >> On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: > >>> > >>> On 07/25/2018 08:57 AM, Jakub Jelinek wrote: > On Wed, Jul 25, 2018 at

Re: PING [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-02 Thread Joseph Myers
On Wed, 1 Aug 2018, Martin Sebor wrote: > Richard, do you have any further comments or suggestions or is > the patch acceptable? > > I realize it's not ideal but I don't see how to achieve the ideal > (understanding PTRDIFF_MAX) without deferring the processing of > these options until the back

PING [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-01 Thread Martin Sebor
Richard, do you have any further comments or suggestions or is the patch acceptable? I realize it's not ideal but I don't see how to achieve the ideal (understanding PTRDIFF_MAX) without deferring the processing of these options until the back end has been initialized. It would still mean

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-26 Thread Martin Sebor
On 07/26/2018 08:58 AM, Martin Sebor wrote: On 07/26/2018 02:38 AM, Richard Biener wrote: On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: On 07/25/2018 08:57 AM, Jakub Jelinek wrote: On Wed, Jul 25, 2018 at 08:54:13AM -0600, Martin Sebor wrote: I don't mean for the special value to be

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-26 Thread Martin Sebor
On 07/26/2018 02:38 AM, Richard Biener wrote: On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: On 07/25/2018 08:57 AM, Jakub Jelinek wrote: On Wed, Jul 25, 2018 at 08:54:13AM -0600, Martin Sebor wrote: I don't mean for the special value to be used except internally for the defaults.

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-26 Thread Richard Biener
On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: > > On 07/25/2018 08:57 AM, Jakub Jelinek wrote: > > On Wed, Jul 25, 2018 at 08:54:13AM -0600, Martin Sebor wrote: > >> I don't mean for the special value to be used except internally > >> for the defaults. Otherwise, users wanting to override

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-25 Thread Martin Sebor
On 07/25/2018 08:57 AM, Jakub Jelinek wrote: On Wed, Jul 25, 2018 at 08:54:13AM -0600, Martin Sebor wrote: I don't mean for the special value to be used except internally for the defaults. Otherwise, users wanting to override the default will choose a value other than it. I'm happy to

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-25 Thread Jakub Jelinek
On Wed, Jul 25, 2018 at 08:54:13AM -0600, Martin Sebor wrote: > I don't mean for the special value to be used except internally > for the defaults. Otherwise, users wanting to override the default > will choose a value other than it. I'm happy to document it in > the .opt file for internal users

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-25 Thread Martin Sebor
On 07/25/2018 02:34 AM, Richard Biener wrote: On Wed, Jul 25, 2018 at 4:07 AM Martin Sebor wrote: The very large option argument enhancement committed last week inadvertently introduced an assumption about the LP64 data model that makes the -Wxxx-larger-than options have a different effect at

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-25 Thread Richard Biener
On Wed, Jul 25, 2018 at 4:07 AM Martin Sebor wrote: > > The very large option argument enhancement committed last week > inadvertently introduced an assumption about the LP64 data model > that makes the -Wxxx-larger-than options have a different effect > at their default documented setting of

[PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-07-24 Thread Martin Sebor
The very large option argument enhancement committed last week inadvertently introduced an assumption about the LP64 data model that makes the -Wxxx-larger-than options have a different effect at their default documented setting of PTRDIFF_MAX between ILP32 and LP64. As a result, the options are