Re: [PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-11 Thread xndcn
Thanks, now I have totally understand! I think it deserves a clearer prompt, but I do not have a better idea currently. So forget it, thanks! 在 2023年12月11日星期一,Richard Biener 写道: > On Mon, Dec 11, 2023 at 12:39 PM xndcn wrote: > > > > Got it, thanks! It is really confusing >,< > > What about

Re: [PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-11 Thread Richard Biener
On Mon, Dec 11, 2023 at 12:39 PM xndcn wrote: > > Got it, thanks! It is really confusing >,< > What about the first one? For case MEM_REF. The same - the LHS determines this is a store, if it is the RHS is invalid as diagnosed (it needs to go through a temporary). Richard. > 在

Re: [PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-11 Thread xndcn
Got it, thanks! It is really confusing >,< What about the first one? For case MEM_REF. 在 2023年12月11日星期一,Richard Biener 写道: > On Sun, Dec 10, 2023 at 4:00 PM xndcn wrote: > > > > Hi, I am a newbie in GCC, and I do not have access to git repo. > > > > I found some misleading error messages in

Re: [PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-10 Thread Richard Biener
On Sun, Dec 10, 2023 at 4:00 PM xndcn wrote: > > Hi, I am a newbie in GCC, and I do not have access to git repo. > > I found some misleading error messages in verify_gimple_assign_single > function of tree-cfg.cc. It prompt error "invalid RHS for gimple memory > store: ", but it checks lhs in

[PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single.

2023-12-10 Thread xndcn
gcc/ChangeLog: * tree-cfg.cc (verify_gimple_assign_single): Fix misleading error, from "invalid LHS ..." to "invalid RHS ..." Signed-off-by: xndcn --- gcc/tree-cfg.cc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/tree-cfg.cc b/gcc/tree-cfg.cc index

[PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-10 Thread xndcn
Sorry about the attachment, re-paste here

[PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single

2023-12-10 Thread xndcn
fe Mon Sep 17 00:00:00 2001 From: xndcn Date: Sun, 10 Dec 2023 22:38:16 +0800 Subject: [PATCH] tree-cfg: Fix misleading error message in verify_gimple_assign_single. gcc/ChangeLog: * tree-cfg.cc (verify_gimple_assign_single): Fix misleading error, from "invalid LHS ..." to "inv