Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-25 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 25, 2023 at 12:27:13PM +0100, Jakub Jelinek via Gcc-patches wrote: > On Wed, Jan 25, 2023 at 06:22:56AM -0500, Siddhesh Poyarekar wrote: > > On 2023-01-25 02:44, Richard Biener wrote: > > > > t = TREE_OPERAND (expr, 1); > > > > - off = size_binop (PLUS_EXPR,

Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-25 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 25, 2023 at 06:22:56AM -0500, Siddhesh Poyarekar wrote: > On 2023-01-25 02:44, Richard Biener wrote: > > > t = TREE_OPERAND (expr, 1); > > > - off = size_binop (PLUS_EXPR, DECL_FIELD_OFFSET (t), > > > + off = size_binop (PLUS_EXPR, > > > +

Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-25 Thread Siddhesh Poyarekar
On 2023-01-25 02:44, Richard Biener wrote: t = TREE_OPERAND (expr, 1); - off = size_binop (PLUS_EXPR, DECL_FIELD_OFFSET (t), + off = size_binop (PLUS_EXPR, + (TREE_OPERAND (expr, 2) ? TREE_OPERAND (expr, 2) +: DECL_FIELD_OFFSET

Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-25 Thread Jakub Jelinek via Gcc-patches
On Wed, Jan 25, 2023 at 08:44:31AM +0100, Richard Biener wrote: > > --- a/gcc/tree-object-size.cc > > +++ b/gcc/tree-object-size.cc > > @@ -412,7 +412,9 @@ compute_object_offset (const_tree expr, const_tree var) > > return base; > > > >t = TREE_OPERAND (expr, 1); > > - off =

Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-24 Thread Richard Biener via Gcc-patches
On Tue, Jan 24, 2023 at 10:54 PM Siddhesh Poyarekar wrote: > > Use the offset in TREE_OPERAND(component_ref, 2) when available instead > of DECL_FIELD_OFFSET when trying to compute offset for a COMPONENT_REF. > > OK for gcc 13 and gcc 12? > > Co-authored-by: Jakub Jelinek > > gcc/ChangeLog: > >

Re: [PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-24 Thread Jakub Jelinek via Gcc-patches
On Tue, Jan 24, 2023 at 04:54:00PM -0500, Siddhesh Poyarekar wrote: > Use the offset in TREE_OPERAND(component_ref, 2) when available instead > of DECL_FIELD_OFFSET when trying to compute offset for a COMPONENT_REF. > > OK for gcc 13 and gcc 12? Ok for trunk, I'd wait a week or two with the

[PATCH] tree-optimization/108522 Use COMPONENT_REF offset when available

2023-01-24 Thread Siddhesh Poyarekar
Use the offset in TREE_OPERAND(component_ref, 2) when available instead of DECL_FIELD_OFFSET when trying to compute offset for a COMPONENT_REF. OK for gcc 13 and gcc 12? Co-authored-by: Jakub Jelinek gcc/ChangeLog: PR tree-optimization/108522 * tree-object-size.cc