Martin Sebor mse...@gmail.com writes:
gcc/testsuite/ChangeLog
2015-07-28 Martin Sebor mse...@redhat.com
* g++.dg/Wframe-address-in-Wall.C: New test.
* g++.dg/Wframe-address.C: New test.
* g++.dg/Wno-frame-address.C: New test.
* gcc.dg/Wframe-address-in-Wall.c: New test.
On 28/07/15 16:44, Martin Sebor wrote:
Attached is an updated patch with the changes above.
gcc/testsuite/ChangeLog
2015-07-28 Martin Sebormse...@redhat.com
* g++.dg/Wframe-address-in-Wall.C: New test.
* g++.dg/Wframe-address.C: New test.
* g++.dg/Wno-frame-address.C: New
On 08/05/2015 10:02 AM, Jiong Wang wrote:
On 28/07/15 16:44, Martin Sebor wrote:
Attached is an updated patch with the changes above.
gcc/testsuite/ChangeLog
2015-07-28 Martin Sebormse...@redhat.com
* g++.dg/Wframe-address-in-Wall.C: New test.
* g++.dg/Wframe-address.C: New
OK for the trunk. Sorry for the delay.
Thank you. Committed in revision 226480.
Martin
On 07/28/2015 09:44 AM, Martin Sebor wrote:
gcc/ChangeLog
2015-07-27 Martin Sebor mse...@redhat.com
* c-family/c.opt (-Wbuiltin-address): New warning option.
* doc/invoke.texi (Wbuiltin-address): Document it.
* doc/extend.texi (__builtin_frame_addrress,
On Mon, Jul 27, 2015 at 09:08:34PM -0600, Martin Sebor wrote:
So, my suggestion would be to warn for any call with a nonzero value.
The current documentation says that you should only use nonzero values
for debug purposes. A warning would help yes, how many people read the
manual after all
gcc/ChangeLog
2015-07-27 Martin Sebor mse...@redhat.com
* c-family/c.opt (-Wbuiltin-address): New warning option.
* doc/invoke.texi (Wbuiltin-address): Document it.
* doc/extend.texi (__builtin_frame_addrress, __builtin_return_addrress):
Typoes (rr).
Fixed.
- rtx
So, my suggestion would be to warn for any call with a nonzero value.
The current documentation says that you should only use nonzero values
for debug purposes. A warning would help yes, how many people read the
manual after all :-)
Thank you both for the feedback. Attached is a simplified
On Thu, Jul 23, 2015 at 11:08:21PM -0600, Jeff Law wrote:
There's the following comment in expand_builtin_frame_address:
/* Some ports cannot access arbitrary stack frames. */
just before a block of code where the function can lead to
an invalid argument warning which would cause
On 06/11/2015 04:05 PM, Martin Sebor wrote:
Attached is an updated patch for both GCC and the manual.
The patch implements the suggested warning, -Wbuiltin-address,
that issues diagnostics for unsafe calls of the builtin address
functions. Safe calls are those with arguments 0 or 1 anywhere
in
On 07/07/2015 04:41 AM, Martin Sebor wrote:
This is a small change to diagnose unsafe calls to
__builtin_{frame,return}_address (with an argument 2) than
tend to return bogus values or lead to crashes at runtime.
I hadn't realized you went through and implemented the
suggestion. Thanks for
This is a small change to diagnose unsafe calls to
__builtin_{frame,return}_address (with an argument 2) than
tend to return bogus values or lead to crashes at runtime.
A review would be appreciated.
Thanks
Martin
On 06/26/2015 05:49 PM, Martin Sebor wrote:
Is this patch okay for trunk?
On
Is this patch okay for trunk?
On 06/18/2015 11:15 AM, Martin Sebor wrote:
Are there any concerns with or suggestions for changes to
the following patch?
https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00886.html
Thanks
Martin
Are there any concerns with or suggestions for changes to
the following patch?
https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00886.html
Thanks
Martin
Attached is an updated patch for both GCC and the manual.
The patch implements the suggested warning, -Wbuiltin-address,
that issues diagnostics for unsafe calls of the builtin address
functions. Safe calls are those with arguments 0 or 1 anywhere
in a program and argument 2 outside of the main
15 matches
Mail list logo
