Re: [PATCH]AArch64: Fix native detection in the presence of mandatory features which don't have midr values

2023-01-27 Thread Andrew Pinski via Gcc-patches
On Fri, Jan 27, 2023 at 4:12 AM Richard Sandiford via Gcc-patches wrote: > > Tamar Christina writes: > > Hi All, > > > > aarch64-option-extensions.def explicitly defines the semantics for an empty > > midr > > field as being: > > > > In that case this field > > should contain a space

Re: [PATCH]AArch64: Fix native detection in the presence of mandatory features which don't have midr values

2023-01-27 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi Richard, > >> > + /* The smallest set of feature bits to toggle to enable this >> > + option. */ >> >aarch64_feature_flags flag_canonical; >> > - aarch64_feature_flags flags_on; >> > - aarch64_feature_flags flags_off; >> > + /* If this feature is turned on,

RE: [PATCH]AArch64: Fix native detection in the presence of mandatory features which don't have midr values

2023-01-27 Thread Tamar Christina via Gcc-patches
Hi Richard, > > + /* The smallest set of feature bits to toggle to enable this > > + option. */ > >aarch64_feature_flags flag_canonical; > > - aarch64_feature_flags flags_on; > > - aarch64_feature_flags flags_off; > > + /* If this feature is turned on, these bits also need to be turned >

Re: [PATCH]AArch64: Fix native detection in the presence of mandatory features which don't have midr values

2023-01-27 Thread Richard Sandiford via Gcc-patches
Tamar Christina writes: > Hi All, > > aarch64-option-extensions.def explicitly defines the semantics for an empty > midr > field as being: > > In that case this field > should contain a space (" ") separated list of the strings in 'Features' > that are required. Their order is

[PATCH]AArch64: Fix native detection in the presence of mandatory features which don't have midr values

2023-01-27 Thread Tamar Christina via Gcc-patches
Hi All, aarch64-option-extensions.def explicitly defines the semantics for an empty midr field as being: In that case this field should contain a space (" ") separated list of the strings in 'Features' that are required. Their order is not important. An empty string means