Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-17 Thread Thomas Schwinge
Hi Chung-Lin! On Fri, 14 Dec 2018 22:28:58 +0800, Chung-Lin Tang wrote: > On 2018/12/13 11:51 PM, Thomas Schwinge wrote: > > On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin > > Tang wrote: > >> On 2018/12/7 6:26 AM, Julian Brown wrote: > >>> On Thu, 6 Dec 2018 22:22:46 + > >>> Julian Brown

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-14 Thread Thomas Schwinge
Hi Chung-Lin! On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang wrote: > This patch is a re-organization of OpenACC asynchronous queues. Again, many thanks for that! In addition to the review emails I just posted, I've also put all that stuff into a GitHub branch:

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-14 Thread Chung-Lin Tang
On 2018/12/13 11:51 PM, Thomas Schwinge wrote: On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin Tang wrote: On 2018/12/7 6:26 AM, Julian Brown wrote: On Thu, 6 Dec 2018 22:22:46 + Julian Brown wrote: On Thu, 6 Dec 2018 21:42:14 +0100 Thomas Schwinge wrote: [...] ..., where the

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-14 Thread Thomas Schwinge
Hi Chung-Lin! A little bit of documentation starter update for you to include. Please make sure that all relevant functions have such comments addded. commit 7e0896281d155e1544751f43c1eaace8e005e019 Author: Thomas Schwinge Date: Thu Dec 13 17:59:46 2018 +0100 [WIP] into async re-work:

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-14 Thread Thomas Schwinge
Hi Chung-Lin! On Thu, 06 Dec 2018 21:42:14 +0100, I wrote: > On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang > wrote: > > Also included in this patch is the code for the acc_get/set_default_async > > API functions in OpenACC 2.5. > > It's a minor part of this patch, but since some code was

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-13 Thread Thomas Schwinge
Hi! On Thu, 13 Dec 2018 23:28:49 +0800, Chung-Lin Tang wrote: > On 2018/12/7 6:26 AM, Julian Brown wrote: > > On Thu, 6 Dec 2018 22:22:46 + > > Julian Brown wrote: > > > >> On Thu, 6 Dec 2018 21:42:14 +0100 > >> Thomas Schwinge wrote: > >> > >>> [...] > >>> ..., where the "Invalid read

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-13 Thread Chung-Lin Tang
On 2018/12/7 6:26 AM, Julian Brown wrote: On Thu, 6 Dec 2018 22:22:46 + Julian Brown wrote: On Thu, 6 Dec 2018 21:42:14 +0100 Thomas Schwinge wrote: [...] ..., where the "Invalid read of size 8" happens, and which eventually would try to "free (tgt)" again, via

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-06 Thread Julian Brown
On Thu, 6 Dec 2018 22:22:46 + Julian Brown wrote: > On Thu, 6 Dec 2018 21:42:14 +0100 > Thomas Schwinge wrote: > > > [...] > > ..., where the "Invalid read of size 8" happens, and which > > eventually would try to "free (tgt)" again, via > > libgomp/target.c:gomp_unmap_tgt: > > > >

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-06 Thread Julian Brown
On Thu, 6 Dec 2018 21:42:14 +0100 Thomas Schwinge wrote: > [...] > ..., where the "Invalid read of size 8" happens, and which eventually > would try to "free (tgt)" again, via libgomp/target.c:gomp_unmap_tgt: > > attribute_hidden void > gomp_unmap_tgt (struct target_mem_desc *tgt) >

Re: [PATCH 0/6, OpenACC, libgomp] Async re-work

2018-12-06 Thread Thomas Schwinge
Hi Chung-Lin! On Tue, 25 Sep 2018 21:09:49 +0800, Chung-Lin Tang wrote: > This patch is a re-organization of OpenACC asynchronous queues. Thanks! > The previous style of implementation > was essentially re-defining the entire async API inside the plugin-interface, > and relaying all such >

[PATCH 0/6, OpenACC, libgomp] Async re-work

2018-09-25 Thread Chung-Lin Tang
This patch is a re-organization of OpenACC asynchronous queues. The previous style of implementation was essentially re-defining the entire async API inside the plugin-interface, and relaying all such API calls to the target plugin, which is awkward in design; it requires (each) target plugin