Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-10-11 Thread David Malcolm
On Mon, 2017-07-24 at 16:04 -0400, David Malcolm wrote: > We currently capture some source location information in the > frontends, but there are many kinds of source entity for which we > *don't* > retain the location information after the initial parse. > > For example, in the C/C++ frontends: >

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-28 Thread Martin Sebor
Thanks for the explanation (snipped). * C++: add a fix-it hint to -Wsuggest-final-methods To answer your call for other ideas below: There are other suggestions that GCC could offer to help improve code, including * to add the const qualifier to function pointer and reference argument

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-28 Thread David Malcolm
On Thu, 2017-07-27 at 13:51 -0600, Martin Sebor wrote: > I think this is great. My overall question is: is the new BLT > representation available in the middle-end? Given that, err, I'm not freeing it anywhere yet (ahem), the answer is yes. Although it lives in the "gcc" dir, the generated tre

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-27 Thread Alexandre Oliva
On Jul 26, 2017, Jim Wilson wrote: > On 07/24/2017 01:04 PM, David Malcolm wrote: >> * The LSP implementation is a just a proof-of-concept, to further >> motivate capturing the extra data. Turning it into a "proper" LSP >> server implementation would be a *lot* more work, and I'm unlikely to >>

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-27 Thread Martin Sebor
I think this is great. My overall question is: is the new BLT representation available in the middle-end? If not, do you have plans to make it available? (I think it might be especially useful there, to either accurately highlight the source of a problem when it's far removed from the problem s

Re: [PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-26 Thread Jim Wilson
On 07/24/2017 01:04 PM, David Malcolm wrote: * The LSP implementation is a just a proof-of-concept, to further motivate capturing the extra data. Turning it into a "proper" LSP server implementation would be a *lot* more work, and I'm unlikely to actually do that (but maybe someone on t

[PATCH 00/17] RFC: New source-location representation; Language Server Protocol

2017-07-24 Thread David Malcolm
We currently capture some source location information in the frontends, but there are many kinds of source entity for which we *don't* retain the location information after the initial parse. For example, in the C/C++ frontends: * we don't capture the locations of the individual parameters with