On Fri, Jun 04, 2021 at 01:03:34PM -0600, Martin Sebor wrote:
> Also, "insn" is not a word, and even though it's common abbreviation
> in GCC speak it's not necessarily something all users are familiar
> with, and doesn't lend itself to translation. Please spell out
> the word instead.
This is a
On 6/1/21 11:04 PM, Kewen Lin via Gcc-patches wrote:
As Segher suggested, this patch is to emit the error message
if the split condition of define_insn_and_split is empty while
the insn condition isn't.
gcc/ChangeLog:
* gensupport.c (process_rtx): Emit error message for empty
On Wed, Jun 02, 2021 at 04:18:46PM +0800, Kewen.Lin wrote:
> on 2021/6/2 下午3:43, Richard Biener wrote:
> Yes, the "" in split condition does mean 'true' (always).
Right -- which means it will be split whenever it matches. This *can*
be intended, but in define_insn_and_split it is almost always a
on 2021/6/2 下午3:43, Richard Biener wrote:
> On Wed, Jun 2, 2021 at 9:28 AM Kewen.Lin wrote:
>>
>> Hi Richi,
>>
>> on 2021/6/2 下午3:04, Richard Biener wrote:
>>> On Wed, Jun 2, 2021 at 7:05 AM Kewen Lin wrote:
As Segher suggested, this patch is to emit the error message
if the split
On Wed, Jun 2, 2021 at 9:28 AM Kewen.Lin wrote:
>
> Hi Richi,
>
> on 2021/6/2 下午3:04, Richard Biener wrote:
> > On Wed, Jun 2, 2021 at 7:05 AM Kewen Lin wrote:
> >>
> >> As Segher suggested, this patch is to emit the error message
> >> if the split condition of define_insn_and_split is empty
Hi Richi,
on 2021/6/2 下午3:04, Richard Biener wrote:
> On Wed, Jun 2, 2021 at 7:05 AM Kewen Lin wrote:
>>
>> As Segher suggested, this patch is to emit the error message
>> if the split condition of define_insn_and_split is empty while
>> the insn condition isn't.
>
> I wonder whether it would
On Wed, Jun 2, 2021 at 7:05 AM Kewen Lin wrote:
>
> As Segher suggested, this patch is to emit the error message
> if the split condition of define_insn_and_split is empty while
> the insn condition isn't.
I wonder whether it would be a good idea to automagically make
the split condition "&& 1"
As Segher suggested, this patch is to emit the error message
if the split condition of define_insn_and_split is empty while
the insn condition isn't.
gcc/ChangeLog:
* gensupport.c (process_rtx): Emit error message for empty
split condition in define_insn_and_split while the insn
