Re: [PATCH 1/3] Come up with startswith function.

2021-05-18 Thread Ian Lance Taylor via Gcc-patches
On Tue, May 18, 2021 at 5:32 AM Martin Liška wrote: > > On 5/18/21 12:07 PM, Iain Buclaw wrote: > > Excerpts from Martin Liska's message of March 17, 2021 4:36 pm: > >> > >> gcc/d/ChangeLog: > >> > >> * d-builtins.cc (do_build_builtin_fn): Use startswith > >> function instead of

Re: [PATCH 1/3] Come up with startswith function.

2021-05-18 Thread Martin Liška
On 5/18/21 12:07 PM, Iain Buclaw wrote: Excerpts from Martin Liska's message of March 17, 2021 4:36 pm: gcc/d/ChangeLog: * d-builtins.cc (do_build_builtin_fn): Use startswith function instead of strncmp. * dmd/dinterpret.c (evaluateIfBuiltin): Likewise. *

Re: [PATCH 1/3] Come up with startswith function.

2021-05-18 Thread Iain Buclaw via Gcc-patches
Excerpts from Martin Liska's message of March 17, 2021 4:36 pm: > > gcc/d/ChangeLog: > > * d-builtins.cc (do_build_builtin_fn): Use startswith > function instead of strncmp. > * dmd/dinterpret.c (evaluateIfBuiltin): Likewise. > * dmd/dmangle.c: Likewise. > *

Re: [PATCH 1/3] Come up with startswith function.

2021-05-10 Thread Richard Biener via Gcc-patches
On Wed, Apr 21, 2021 at 11:39 AM Martin Liška wrote: > > On 4/21/21 9:32 AM, Arnaud Charlet wrote: > >> gcc/ada/ChangeLog: > >> > >> * adadecode.c (has_prefix): Remove has_prefix and replace it > >> with startswith. > >> (__gnat_decode): Likewise. > > > > This change is not OK:

Re: [PATCH 1/3] Come up with startswith function.

2021-04-25 Thread Arnaud Charlet
> Thank you for a quick reply. > There's an updated version of the patch. The Ada part is OK now, thanks.

Re: [PATCH 1/3] Come up with startswith function.

2021-04-21 Thread Martin Liška
runtime/target file. > > Only the change in utils.c is OK. > > Arno > Thank you for a quick reply. There's an updated version of the patch. Cheers, Martin >From 23431b3fa6e0ad69e66cc7d3fe8bee5da29a Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 17 Mar 2021 16:36:44 +

Re: [PATCH 1/3] Come up with startswith function.

2021-04-21 Thread Arnaud Charlet
> gcc/ada/ChangeLog: > > * adadecode.c (has_prefix): Remove has_prefix and replace it > with startswith. > (__gnat_decode): Likewise. This change is not OK: adadecode.c is also a runtime file and as such cannot include compiler include files. > * gcc-interface/utils.c

[PATCH 1/3] Come up with startswith function.

2021-04-21 Thread Martin Liska
gcc/ada/ChangeLog: * adadecode.c (has_prefix): Remove has_prefix and replace it with startswith. (__gnat_decode): Likewise. * gcc-interface/utils.c (def_builtin_1): Use startswith function instead of strncmp. * init.c (__gnat_install_handler):