Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> As that may not be obvious to the reader, I'd like to have the >> 'TREE_ADDRESSABLE' conditionalization be documented in the code. You >> had explained that in >>

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> On 2021-02-26T04:34:50-0800, Julian Brown >> wrote: >> > Two new target hooks are introduced: >> > TARGET_GOACC_ADJUST_PRIVATE_DECL and TARGET_GOACC_EXPAND_VAR_DECL. >> > The fi

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-02-26T04:34:50-0800, Julian Brown wrote: > --- a/gcc/internal-fn.c > +++ b/gcc/internal-fn.c > @@ -2957,6 +2957,8 @@ expand_UNIQUE (internal_fn, gcall *stmt) >else > gcc_unreachable (); >break; > +case IFN_UNIQUE_OACC_PRIVATE: > + break; > } > >

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-19T12:23:56+0100, Julian Brown wrote: > On Thu, 15 Apr 2021 19:26:54 +0200 > Thomas Schwinge wrote: >> This has iterated through several conceptually different designs and >> implementations, by several people, over the past several years. > > I hope this wasn't a hint that I'd fa

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi, (Chung-Lin, question for you buried below.) On Thu, 15 Apr 2021 19:26:54 +0200 Thomas Schwinge wrote: > Hi! > > On 2021-02-26T04:34:50-0800, Julian Brown > wrote: > > This patch > > Thanks, Julian, for your continued improving of these changes! You're welcome! > This has iterated thr

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-18T23:53:01+0100, Andrew Stubbs wrote: > On 16/04/2021 18:30, Thomas Schwinge wrote: >> On 2021-04-16T17:05:24+0100, Andrew Stubbs wrote: >>> On 15/04/2021 18:26, Thomas Schwinge wrote: > and optimisation, since shared memory might be faster than > the main memory on a GPU

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

On 16/04/2021 18:30, Thomas Schwinge wrote: Hi! On 2021-04-16T17:05:24+0100, Andrew Stubbs wrote: On 15/04/2021 18:26, Thomas Schwinge wrote: and optimisation, since shared memory might be faster than the main memory on a GPU. Do we potentially have a problem that making more use of (scarce

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-04-16T17:05:24+0100, Andrew Stubbs wrote: > On 15/04/2021 18:26, Thomas Schwinge wrote: >>> and optimisation, since shared memory might be faster than >>> the main memory on a GPU. >> >> Do we potentially have a problem that making more use of (scarce) >> gang-private memory may negat

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

On 15/04/2021 18:26, Thomas Schwinge wrote: and optimisation, since shared memory might be faster than the main memory on a GPU. Do we potentially have a problem that making more use of (scarce) gang-private memory may negatively affect peformance, because potentially fewer OpenACC gangs may th

Re: [PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

Hi! On 2021-02-26T04:34:50-0800, Julian Brown wrote: > This patch Thanks, Julian, for your continued improving of these changes! This has iterated through several conceptually different designs and implementations, by several people, over the past several years. It's now been made my task to f

[PATCH 1/3] openacc: Add support for gang local storage allocation in shared memory

This patch implements a method to track the "private-ness" of OpenACC variables declared in offload regions in gang-partitioned, worker-partitioned or vector-partitioned modes. Variables declared implicitly in scoped blocks and those declared "private" on enclosing directives (e.g. "acc parallel")