Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Tue, Nov 10, 2015 at 11:02:04PM +0100, Bernd Schmidt wrote: > On 11/09/2015 11:53 PM, Trevor Saunders wrote: > >I don't really know him, but I don't really disagree with where he wants > >to get to. However I think we work fairly different ways, and review > >things differently. When I review

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 11:53 PM, Trevor Saunders wrote: I don't really know him, but I don't really disagree with where he wants to get to. However I think we work fairly different ways, and review things differently. When I review patches (mostly for stuff more directly related to Mozilla my standards

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Nov 9, 2015, at 11:46 AM, Jeff Law wrote: On 11/09/2015 12:38 PM, Bernd Schmidt wrote: >> We might want to think about making a policy decision to try waiving >> some of the testing requirements for target macro -> hook conversions. >> Maybe try only a "build to cc1"

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 12:46:33PM -0700, Jeff Law wrote: > On 11/09/2015 12:38 PM, Bernd Schmidt wrote: > >On 11/09/2015 07:52 PM, Trevor Saunders wrote: > > > >>yeah, that's more or less my thought, and this makes hookization easier > >>since you can now mechanically add a hook for each thing in

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 02:30 PM, Trevor Saunders wrote: So in general when I've done cross target things I think I've found more bugs with config-list.mk than with a regtest, but the regtest has found some things I think. I'm finding config-list.mk fairly reliable, with the notable exception of the

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, 9 Nov 2015, Trevor Saunders wrote: > The add default macro definitions then wrap those with hooks, then > target by target replace the macro by hook overrides approach seems to > provide that you can incrementally test and fiind most of the issues, > but the change a macro every where

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2015-11-09 Trevor Saunders * defaults.h (EH_RETURN_HANDLER_RTX): New default definition. * df-scan.c

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, 2015-11-09 at 11:47 -0500, tbsaunde+...@tbsaunde.org wrote: > From: Trevor Saunders > > gcc/ChangeLog: > > 2015-11-09 Trevor Saunders > > * defaults.h (EH_RETURN_HANDLER_RTX): New default definition. > * df-scan.c

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 07:42 PM, Jeff Law wrote: On 11/09/2015 11:27 AM, Bernd Schmidt wrote: On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2015-11-09 Trevor Saunders * defaults.h

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 11:27 AM, Bernd Schmidt wrote: On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2015-11-09 Trevor Saunders * defaults.h (EH_RETURN_HANDLER_RTX): New default definition.

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 11:42:19AM -0700, Jeff Law wrote: > On 11/09/2015 11:27 AM, Bernd Schmidt wrote: > >On 11/09/2015 05:47 PM, tbsaunde+...@tbsaunde.org wrote: > >>From: Trevor Saunders > >> > >>gcc/ChangeLog: > >> > >>2015-11-09 Trevor Saunders

[PATCH 10/12] always define EH_RETURN_HANDLER_RTX

From: Trevor Saunders gcc/ChangeLog: 2015-11-09 Trevor Saunders * defaults.h (EH_RETURN_HANDLER_RTX): New default definition. * df-scan.c (df_get_exit_block_use_set): Adjust. * except.c (expand_eh_return):

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 12:38 PM, Bernd Schmidt wrote: On 11/09/2015 07:52 PM, Trevor Saunders wrote: yeah, that's more or less my thought, and this makes hookization easier since you can now mechanically add a hook for each thing in defaults.h that invokes the macro. Then for each target you can go

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On 11/09/2015 07:52 PM, Trevor Saunders wrote: yeah, that's more or less my thought, and this makes hookization easier since you can now mechanically add a hook for each thing in defaults.h that invokes the macro. Then for each target you can go through and replace the macro with an override

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

On Mon, Nov 09, 2015 at 03:07:21PM -0700, Jeff Law wrote: > On 11/09/2015 02:30 PM, Trevor Saunders wrote: > > > >So in general when I've done cross target things I think I've found more > >bugs with config-list.mk than with a regtest, but the regtest has found > >some things I think. > I'm