Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/25/2016 11:15 AM, Martin Liška wrote: Sure. Just working on that. Great, thank you! -- Pierre-Marie de Rodat

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/25/2016 11:14 AM, Pierre-Marie de Rodat wrote: > Understood. Martin, as the ENABLE_CHECKING refactoring is not comitted yet, > could you do the substitution ENABLE_CHECKING → CHECKING_P for these > dwarf2out.* occurences as part of it? Sure. Just working on that. Martin

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/25/2016 10:24 AM, Richard Biener wrote: So what about removing the field (in struct dw_loc_descr_node) and replacing the visited hash set with a frame_offset hash map (in resolve_args_picking)? This hash map would remember the information we currently store in the field. Sounds

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On Wed, Feb 24, 2016 at 3:16 PM, Martin Liška wrote: > On 02/23/2016 04:21 PM, Richard Biener wrote: >> On Wed, Nov 4, 2015 at 4:03 PM, Mikhail Maltsev wrote: >>> On 11/03/2015 02:35 AM, Jeff Law wrote: This is good fore the trunk too. Please install.

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On Wed, Feb 24, 2016 at 4:43 PM, Pierre-Marie de Rodat wrote: > On 02/24/2016 03:53 PM, Martin Liška wrote: >> >> On 02/24/2016 03:27 PM, Michael Matz wrote: >>> >>> But nothing can set ENABLE_CHECKING anymore (the macro is meanwhile >>> called >>> CHECKING_P), so all that

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/24/2016 03:53 PM, Martin Liška wrote: On 02/24/2016 03:27 PM, Michael Matz wrote: But nothing can set ENABLE_CHECKING anymore (the macro is meanwhile called CHECKING_P), so all that code is dead anyway. So either the new macro should be used or that code should be removed. Good point,

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/24/2016 03:27 PM, Michael Matz wrote: > But nothing can set ENABLE_CHECKING anymore (the macro is meanwhile called > CHECKING_P), so all that code is dead anyway. So either the new macro > should be used or that code should be removed. > > > Ciao, > Michael. Good point, well the change

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

Hi, On Wed, 24 Feb 2016, Martin Liška wrote: > >> grep ENABLE_CHECKING *.[ch] > > dwarf2out.c:#if ENABLE_CHECKING > > dwarf2out.c:#if ENABLE_CHECKING > > dwarf2out.c:#if ENABLE_CHECKING > > dwarf2out.h:#if ENABLE_CHECKING > > Hi Richi. > > Removal in dwarf2out.c is not possible due to

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 02/23/2016 04:21 PM, Richard Biener wrote: > On Wed, Nov 4, 2015 at 4:03 PM, Mikhail Maltsev wrote: >> On 11/03/2015 02:35 AM, Jeff Law wrote: >>> This is good fore the trunk too. Please install. >>> >>> Thanks! >>> >>> jeff >> >> Committed as r229758. > >> grep

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On Wed, Nov 4, 2015 at 4:03 PM, Mikhail Maltsev wrote: > On 11/03/2015 02:35 AM, Jeff Law wrote: >> This is good fore the trunk too. Please install. >> >> Thanks! >> >> jeff > > Committed as r229758. > grep ENABLE_CHECKING *.[ch] dwarf2out.c:#if ENABLE_CHECKING

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 11/01/2015 11:34 PM, Bernhard Reutner-Fischer wrote: > Mikhail, > > On November 1, 2015 9:19:19 PM GMT+01:00, Mikhail Maltsev > wrote: >> This patch cleans up remaining bits related to ENABLE_CHECKING. After >> applying >> this patch (on top of part 9) we will no longer

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 11/03/2015 02:35 AM, Jeff Law wrote: > This is good fore the trunk too. Please install. > > Thanks! > > jeff Committed as r229758. -- Regards, Mikhail Maltsev

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

On 11/01/2015 01:19 PM, Mikhail Maltsev wrote: This patch cleans up remaining bits related to ENABLE_CHECKING. After applying this patch (on top of part 9) we will no longer have any references to ENABLE_CHECKING in the source code. Bootstrapped and regtested (on top of part 9) on

[PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

This patch cleans up remaining bits related to ENABLE_CHECKING. After applying this patch (on top of part 9) we will no longer have any references to ENABLE_CHECKING in the source code. Bootstrapped and regtested (on top of part 9) on x86_64-pc-linux-gnu with --enable-checking=yes and