Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-31 Thread Andrea Corallo
Richard Earnshaw writes: > On 17/03/2020 12:34, Wilco Dijkstra wrote: >> Hi Andrea, >> I think the first part is fine when approved, but the 2nd part is >> problematic like Szabolcs >> already pointed out. We can't just change the ABI or semantics, and these >> builtins are critical >> for

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-17 Thread Richard Earnshaw
On 17/03/2020 12:34, Wilco Dijkstra wrote: Hi Andrea, I think the first part is fine when approved, but the 2nd part is problematic like Szabolcs already pointed out. We can't just change the ABI or semantics, and these builtins are critical for GLIBC performance. We would first need to

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-17 Thread Wilco Dijkstra
Hi Andrea, I think the first part is fine when approved, but the 2nd part is problematic like Szabolcs already pointed out. We can't just change the ABI or semantics, and these builtins are critical for GLIBC performance. We would first need to change GLIBC back to using inline assembler so it

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-17 Thread Andrea Corallo
Andrea Corallo writes: > Hi all, > > second and last patch of the two reworking FPCR and FPSR builtins. > > This rework __builtin_aarch64_set_fpcr (unsigned) and > __builtin_aarch64_set_fpsr (unsigned) to emit a read-modify-sequences > as: > > mrs x1, fpsr > bfi x1, x0,

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-11 Thread Szabolcs Nagy
On 11/03/2020 13:53, Richard Earnshaw (lists) wrote: > On 11/03/2020 13:50, Szabolcs Nagy wrote: >> On 10/03/2020 09:55, Andrea Corallo wrote: >>> Hi all, >>> >>> second and last patch of the two reworking FPCR and FPSR builtins. >>> >>> This rework __builtin_aarch64_set_fpcr (unsigned) and >>>

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-11 Thread Richard Earnshaw (lists)
On 11/03/2020 13:50, Szabolcs Nagy wrote: On 10/03/2020 09:55, Andrea Corallo wrote: Hi all, second and last patch of the two reworking FPCR and FPSR builtins. This rework __builtin_aarch64_set_fpcr (unsigned) and __builtin_aarch64_set_fpsr (unsigned) to emit a read-modify-sequences as:

Re: [PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-11 Thread Szabolcs Nagy
On 10/03/2020 09:55, Andrea Corallo wrote: > Hi all, > > second and last patch of the two reworking FPCR and FPSR builtins. > > This rework __builtin_aarch64_set_fpcr (unsigned) and > __builtin_aarch64_set_fpsr (unsigned) to emit a read-modify-sequences > as: > > mrs x1, fpsr >

[PATCH 2/2] [aarch64] Rework fpcr fpsr getter/setter builtins

2020-03-10 Thread Andrea Corallo
Hi all, second and last patch of the two reworking FPCR and FPSR builtins. This rework __builtin_aarch64_set_fpcr (unsigned) and __builtin_aarch64_set_fpsr (unsigned) to emit a read-modify-sequences as: mrs x1, fpsr bfi x1, x0, 0, 32 msr fpsr, x1 This in