[PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Add calls for several illegal Cilk cases to the C++ frontend. C++ usually doesn't ICE unlike C on illegal cilk, but it's better to match C in what is allowed and what is not. if (_Cilk_spawn ...) is still not errored, but at least it doesn't ICE. gcc/cp/:

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Paolo Carlini
Hi, On 10/03/2014 04:08 PM, Andi Kleen wrote: + if (check_no_cilk (destination, +Cilk array notation cannot be used as a computed goto expression, +%_Cilk_spawn% statement cannot be used as a computed goto expression)) + destination = error_mark_node; Are you sure

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Andi Kleen
On Fri, Oct 03, 2014 at 07:10:05PM +0200, Paolo Carlini wrote: Hi, On 10/03/2014 04:08 PM, Andi Kleen wrote: + if (check_no_cilk (destination, + Cilk array notation cannot be used as a computed goto expression, + %_Cilk_spawn% statement cannot be used as a computed goto

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Paolo Carlini
Hi, On 10/03/2014 07:13 PM, Andi Kleen wrote: On Fri, Oct 03, 2014 at 07:10:05PM +0200, Paolo Carlini wrote: Hi, On 10/03/2014 04:08 PM, Andi Kleen wrote: + if (check_no_cilk (destination, +Cilk array notation cannot be used as a computed goto expression, +%_Cilk_spawn%

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Andi Kleen
I have no idea, but there are lots of error_at() all over while don't use _. So I just follow precedence. The problem is, you are *not* calling error_at directly, you are According to Joseph it's ok because I named the arguments _msgid. -Andi

Re: [PATCH 2/2] Add illegal cilk checks to C++ front.

2014-10-03 Thread Paolo Carlini
Hi, On 10/03/2014 07:50 PM, Andi Kleen wrote: I have no idea, but there are lots of error_at() all over while don't use _. So I just follow precedence. The problem is, you are *not* calling error_at directly, you are According to Joseph it's ok because I named the arguments _msgid. Ok then,