Re: [PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

On 15 September 2017 at 17:57, Kyrill Tkachov wrote: > > Thanks, this is ok once the prerequisites are sorted. Patch 1 was abandoned, and a later version of patch 2 has been committed, so this was applied to trunk as r255112.

Re: [PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

On 15/09/17 16:38, Charles Baylis wrote: On 13 September 2017 at 10:02, Kyrill Tkachov wrote: Please add a comment here saying that the units are in COSTS_N_INSNS so that we can reduce the temptation to use these in inappropriate contexts. + if

Re: [PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

>> + { >> + *cost += current_tune->addr_mode_costs->integer[op_type]; >> + } > > > No need for brackets for single-statement conditionals. Done. From a35fa59f4dc3be42a52519a90bdd2d47e74db086 Mon Sep 17 00:00:00 2001 From: Charles Bayl

Re: [PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

On 13 September 2017 at 10:02, Kyrill Tkachov wrote: > > Please add a comment here saying that the units are in COSTS_N_INSNS > so that we can reduce the temptation to use these in inappropriate contexts. >> + if (VECTOR_MODE_P (mode)) >> + { >> +

Re: [PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

Hi Charles, On 12/09/17 09:34, charles.bay...@linaro.org wrote: From: Charles Baylis This patch adds support for modelling the varying costs of different addressing modes. The generic cost table treats all addressing modes as having equal cost. gcc/ChangeLog:

[PATCH 3/3] [ARM] Add table of costs for AAarch32 addressing modes.

From: Charles Baylis This patch adds support for modelling the varying costs of different addressing modes. The generic cost table treats all addressing modes as having equal cost. gcc/ChangeLog: Charles Baylis *