Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-03-25 Thread Jeff Law via Gcc-patches
On Wed, 2020-01-29 at 18:32 +0300, Alexander Monakov wrote: > On Tue, 28 Jan 2020, Jeff Law wrote: > > > On Tue, 2019-10-08 at 18:04 +0300, Alexander Monakov wrote: > > > On Thu, 3 Oct 2019, Jeff Law wrote: > > > > > > > You may want to review the 2018 discussion: > > > > > > > > https://www.mai

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-29 Thread Alexander Monakov
On Tue, 28 Jan 2020, Jeff Law wrote: > On Tue, 2019-10-08 at 18:04 +0300, Alexander Monakov wrote: > > On Thu, 3 Oct 2019, Jeff Law wrote: > > > > > You may want to review the 2018 discussion: > > > > > > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg185287.html > > > > > > THe 2018 d

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Thu, 2019-10-17 at 16:14 +0300, Alexander Monakov wrote: > On Tue, 8 Oct 2019, Alexander Monakov wrote: > > [massive snip] > > > So in my opinion our CFG is good enough, the real issues with -Wclobbered > > false > > positives are not due to phi nodes but other effects. > > > > If you agree:

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Tue, 2019-10-08 at 18:04 +0300, Alexander Monakov wrote: > On Thu, 3 Oct 2019, Jeff Law wrote: > > > You may want to review the 2018 discussion: > > > > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg185287.html > > > > THe 2018 discussion was primarily concerned with fixing the CFG

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2019-10-17 Thread Alexander Monakov
On Tue, 8 Oct 2019, Alexander Monakov wrote: [massive snip] > So in my opinion our CFG is good enough, the real issues with -Wclobbered > false > positives are not due to phi nodes but other effects. > > If you agree: what would be the next steps? Hello, may I ping this discussion? I apologi

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2019-10-08 Thread Alexander Monakov
On Thu, 3 Oct 2019, Jeff Law wrote: > You may want to review the 2018 discussion: > > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg185287.html > > THe 2018 discussion was primarily concerned with fixing the CFG > inaccuracies which would in turn fix 61118. But would not fix 21161. W

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2019-10-03 Thread Jeff Law
On 10/3/19 6:01 AM, Vladislav Ivanishin wrote: > What it does > > > A fundamental limitation of the new approach is that it requires phi > nodes for variables to perform the analysis it needs to issue the > warning for them. No phis - no warning. In particular, it doesn't deal > wit

[PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2019-10-03 Thread Vladislav Ivanishin
What it does A fundamental limitation of the new approach is that it requires phi nodes for variables to perform the analysis it needs to issue the warning for them. No phis - no warning. In particular, it doesn't deal with register asm variables (see gcc.target/i386/attr-returns_tw