Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

On Mon, Aug 10, 2020 at 10:41 PM Kewen.Lin wrote: > > Hi Bin, > > on 2020/8/10 下午8:38, Bin.Cheng wrote: > > On Mon, Aug 10, 2020 at 12:27 PM Kewen.Lin wrote: > >> > >> Hi Bin, > >> > >> Thanks for the review!! > >> > >> on 2020/8/8 下午4:01, Bin.Cheng wrote: > >>> Hi Kewen, > >>> Sorry for the late

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Hi Bin, on 2020/8/10 下午8:38, Bin.Cheng wrote: > On Mon, Aug 10, 2020 at 12:27 PM Kewen.Lin wrote: >> >> Hi Bin, >> >> Thanks for the review!! >> >> on 2020/8/8 下午4:01, Bin.Cheng wrote: >>> Hi Kewen, >>> Sorry for the late reply. >>> The patch's most important change is below cost computation: >>>

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

On Mon, Aug 10, 2020 at 12:27 PM Kewen.Lin wrote: > > Hi Bin, > > Thanks for the review!! > > on 2020/8/8 下午4:01, Bin.Cheng wrote: > > Hi Kewen, > > Sorry for the late reply. > > The patch's most important change is below cost computation: > > > >> @@ -5890,6 +5973,10 @@ determine_iv_cost (struct

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Hi Bin, Thanks for the review!! on 2020/8/8 下午4:01, Bin.Cheng wrote: > Hi Kewen, > Sorry for the late reply. > The patch's most important change is below cost computation: > >> @@ -5890,6 +5973,10 @@ determine_iv_cost (struct ivopts_data *data, struct >> iv_cand *cand) >> cost_step = add_co

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Hi Kewen, Sorry for the late reply. The patch's most important change is below cost computation: > @@ -5890,6 +5973,10 @@ determine_iv_cost (struct ivopts_data *data, struct > iv_cand *cand) > cost_step = add_cost (data->speed, TYPE_MODE (TREE_TYPE (base))); > cost = cost_step + adjust_setu

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Hi Richard, on 2020/6/2 下午3:14, Richard Sandiford wrote: > "Kewen.Lin" writes: >> Hi Richard, >> >> Thanks for the comments! >> >> on 2020/6/2 上午1:59, Richard Sandiford wrote: >>> Could you go into more detail about this choice of cost calculation? >>> It looks like we first calculate per-group f

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

"Kewen.Lin" writes: > Hi Richard, > > Thanks for the comments! > > on 2020/6/2 上午1:59, Richard Sandiford wrote: >> Could you go into more detail about this choice of cost calculation? >> It looks like we first calculate per-group flags, which are true only if >> the unrolled offsets are valid for

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Hi Richard, Thanks for the comments! on 2020/6/2 上午1:59, Richard Sandiford wrote: > Could you go into more detail about this choice of cost calculation? > It looks like we first calculate per-group flags, which are true only if > the unrolled offsets are valid for all uses in the group. Then we

Re: [PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

Could you go into more detail about this choice of cost calculation? It looks like we first calculate per-group flags, which are true only if the unrolled offsets are valid for all uses in the group. Then we create per-candidate flags when associating candidates with groups. Instead, couldn't we

[PATCH 3/4] ivopts: Consider cost_step on different forms during unrolling

gcc/ChangeLog 2020-MM-DD Kewen Lin * tree-ssa-loop-ivopts.c (struct iv_group): New field reg_offset_p. (struct iv_cand): New field reg_offset_p. (struct ivopts_data): New field consider_reg_offset_for_unroll_p. (dump_groups): Dump group with reg_offset_p.