On 9/16/19 5:04 AM, Richard Biener wrote:
On Wed, 11 Sep 2019, Martin Liška wrote:
On 9/11/19 3:19 PM, Martin Liška wrote:
On 9/11/19 2:43 PM, Richard Biener wrote:
Any particular reason you needed to swap the calls in
maybe_fold_and/or_comparisons?
You didn't answer this, besides that the
On Wed, 11 Sep 2019, Martin Liška wrote:
> On 9/11/19 3:19 PM, Martin Liška wrote:
> > On 9/11/19 2:43 PM, Richard Biener wrote:
> >> Any particular reason you needed to swap the calls in
> >> maybe_fold_and/or_comparisons?
You didn't answer this, besides that the patch is OK.
Thanks,
Richard.
p the calls in
>> maybe_fold_and/or_comparisons?
>>
>> +(for code1 (eq ne)
>> + (for code2 (eq ne lt gt le ge)
>> + (for and (truth_and bit_and)
>> + (simplify
>>
>> You could save some code-bloat with writing
>>
>> (for and (
>>
On 9/11/19 2:43 PM, Richard Biener wrote:
> On Wed, 11 Sep 2019, Martin Liška wrote:
>
>> I'm sending updated version of the patch where I changed
>> from previous version:
>> - more compact matching is used (note @3 and @4):
>> (and (code1:c@3 @0 INTEGER_CST@1) (code2:c@4 @0 INTEGER_CST@2))
>>
On Wed, 11 Sep 2019, Martin Liška wrote:
> I'm sending updated version of the patch where I changed
> from previous version:
> - more compact matching is used (note @3 and @4):
> (and (code1:c@3 @0 INTEGER_CST@1) (code2:c@4 @0 INTEGER_CST@2))
>
> Patch can bootstrap on x86_64-linux-gnu and
,
Martin
>From e21404f55f51701d25a6d859b892b219d2041e02 Mon Sep 17 00:00:00 2001
From: Martin Liska
Date: Fri, 6 Sep 2019 12:34:49 +0200
Subject: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.
gcc/ChangeLog:
2019-09-09 Martin Liska
* genmatch.c (dt_node::append_simplify):
On 9/10/19 1:19 PM, Marc Glisse wrote:
> (some quick comments, I didn't check in details)
Thanks for them.
>
> + (and:c (code1 @0 INTEGER_CST@1) (code2 @0 INTEGER_CST@2))
> [...]
> + (if (code1 == NE_EXPR && !val) (code2 @0 @2
>
> How about
>
> (and:c (code1 @0 INTEGER_CST@1)
On 9/10/19 10:52 AM, Bernhard Reutner-Fischer wrote:
> On 9 September 2019 15:41:05 CEST, "Martin Liška" wrote:
>> On 9/9/19 2:24 PM, Martin Liška wrote:
>>> Hi.
>>>
>>> The patch is about transition of and_comparisons_1 matching
>>> into match.pd.
>>>
>>> Patch can bootstrap on x86_64-linux-gnu
(some quick comments, I didn't check in details)
+(and:c (code1 @0 INTEGER_CST@1) (code2 @0 INTEGER_CST@2))
[...]
+ (if (code1 == NE_EXPR && !val) (code2 @0 @2
How about
(and:c (code1 @0 INTEGER_CST@1) (code2@3 @0 INTEGER_CST@2))
[...]
(if (code1 == NE_EXPR && !val) @3)))
On 9 September 2019 15:41:05 CEST, "Martin Liška" wrote:
>On 9/9/19 2:24 PM, Martin Liška wrote:
>> Hi.
>>
>> The patch is about transition of and_comparisons_1 matching
>> into match.pd.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression
>tests.
>>
>> Ready to be installed?
H 3/5] Rewrite part of and_comparisons_1 into match.pd.
gcc/ChangeLog:
2019-09-09 Martin Liska
* genmatch.c (dt_node::append_simplify): Do not print
warning when we have duplicate patterns belonging
to a same simplify rule.
* gimple-fold.c (same_bool_result_p): Handle SSA_NAMEs
crea
d version (as mentioned in part 1).
Martin
>From a4127ffe3d55c67dc8ef78d62a27277807740995 Mon Sep 17 00:00:00 2001
From: Martin Liska
Date: Fri, 6 Sep 2019 12:34:49 +0200
Subject: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.
gcc/ChangeLog:
2019-09-09 Martin Liska
* genmatch.
, 6 Sep 2019 12:34:49 +0200
Subject: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.
gcc/ChangeLog:
2019-09-09 Martin Liska
* genmatch.c (dt_node::append_simplify): Ignore warning
for the same location.
* gimple-fold.c (same_bool_result_p): Handle newly
created SSA_NAMEs
13 matches
Mail list logo
