Re: [PATCH 5/5] single_set takes an insn

2014-09-09 Thread Jeff Law
On 09/08/14 15:29, David Malcolm wrote: gcc/ChangeLog: * rtl.h (single_set_2): Strengthen first param from const_rtx to const rtx_insn *, and move prototype to above... (single_set): ...this. Convert this from a macro to an inline function, enforcing the

[PATCH 5/5] single_set takes an insn

2014-09-09 Thread David Malcolm
On Tue, 2014-09-09 at 09:53 -0600, Jeff Law wrote: On 09/08/14 15:29, David Malcolm wrote: gcc/ChangeLog: [...] * config/avr/avr.c (avr_out_plus): Add checked cast to rtx_insn * when invoking single_set in region guarded by INSN_P. (avr_out_bitop): Likewise.

Re: [PATCH 5/5] single_set takes an insn

2014-09-09 Thread Jeff Law
On 09/09/14 11:34, David Malcolm wrote: [dropping DJ from CC as this doesn't relate to rl78] [adding Denis to CC due to avr-related discussion] The reason for the as_a rtx_insn * here is that avr_out_plus and avr_out_bitop are mostly called with insns [1], but are also called with SET patterns

[PATCH 5/5] single_set takes an insn

2014-09-08 Thread David Malcolm
gcc/ChangeLog: * rtl.h (single_set_2): Strengthen first param from const_rtx to const rtx_insn *, and move prototype to above... (single_set): ...this. Convert this from a macro to an inline function, enforcing the requirement that the param is a const